| Message ID | 1409239301-3755-2-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On 28 August 2014 09:21, Simon Glass <sjg@chromium.org> wrote: > This option is currently not supported, but needs to be, for buildman to > operate as expected. > > Reported-by: York Sun <yorksun@freescale.com> > Signed-off-by: Simon Glass <sjg@chromium.org> Applied to u-boot-x86/patman.
Hi Simon, 2014-09-06 4:34 GMT+09:00 Simon Glass <sjg@chromium.org>: > On 28 August 2014 09:21, Simon Glass <sjg@chromium.org> wrote: >> This option is currently not supported, but needs to be, for buildman to >> operate as expected. >> >> Reported-by: York Sun <yorksun@freescale.com> >> Signed-off-by: Simon Glass <sjg@chromium.org> > > Applied to u-boot-x86/patman. Really? This patch is already on u-boot/master. commit 042a732cf50568e77a20c540341fccf28ba62bcf Author: Simon Glass <sjg@chromium.org> AuthorDate: Thu Aug 14 21:59:11 2014 -0600 Commit: Simon Glass <sjg@chromium.org> CommitDate: Thu Aug 28 07:56:19 2014 -0700 patman: Support the 'reverse' option for 'git log' This option is currently not supported, but needs to be, for buildman to operate as expected. Reported-by: York Sun <yorksun@freescale.com> Signed-off-by: Simon Glass <sjg@chromium.org> If you really succeeded in applying it, it means u-boot-x86 is out of sync with u-boot/master. I recommend to have your repo fast-forwarded against Tom's one, and then appy patches onto it so as not to double commits.
Hi Simon, 2014-09-06 4:34 GMT+09:00 Simon Glass <sjg@chromium.org>: > On 28 August 2014 09:21, Simon Glass <sjg@chromium.org> wrote: >> This option is currently not supported, but needs to be, for buildman to >> operate as expected. >> >> Reported-by: York Sun <yorksun@freescale.com> >> Signed-off-by: Simon Glass <sjg@chromium.org> > > Applied to u-boot-x86/patman. This one. You had already sent a pull-req to Tom. http://lists.denx.de/pipermail/u-boot/2014-August/187433.html
Hi Masahiro, On 6 September 2014 09:11, Masahiro YAMADA <yamada.m@jp.panasonic.com> wrote: > Hi Simon, > > 2014-09-06 4:34 GMT+09:00 Simon Glass <sjg@chromium.org>: >> On 28 August 2014 09:21, Simon Glass <sjg@chromium.org> wrote: >>> This option is currently not supported, but needs to be, for buildman to >>> operate as expected. >>> >>> Reported-by: York Sun <yorksun@freescale.com> >>> Signed-off-by: Simon Glass <sjg@chromium.org> >> >> Applied to u-boot-x86/patman. > > > This one. You had already sent a pull-req to Tom. > > http://lists.denx.de/pipermail/u-boot/2014-August/187433.html For patches that don't come through a master tree, I don't reply to the mailing list with 'applied' until they are actually applied to mainline. Otherwise I worry that people will wonder what on earth it is applied to. Also, it is possible that these non-master trees will not actually be pulled by Tom. In this case I realised that I hadn't replied, so did so (much after the fact). I'm happy to change my process if there is a better one. Regards, Simon
diff --git a/tools/patman/gitutil.py b/tools/patman/gitutil.py index 735c8dd..e2b4959 100644 --- a/tools/patman/gitutil.py +++ b/tools/patman/gitutil.py @@ -38,6 +38,8 @@ def LogCmd(commit_range, git_dir=None, oneline=False, reverse=False, cmd.append('--oneline') if use_no_decorate: cmd.append('--no-decorate') + if reverse: + cmd.append('--reverse') if count is not None: cmd.append('-n%d' % count) if commit_range:
This option is currently not supported, but needs to be, for buildman to operate as expected. Reported-by: York Sun <yorksun@freescale.com> Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: - Add new patch to fix the 'reverse' bug Changes in v6: None Changes in v5: None tools/patman/gitutil.py | 2 ++ 1 file changed, 2 insertions(+)