diff mbox

[U-Boot] kconfig: remove DEFCONFIG_LIST

Message ID 1408125012-11880-1-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Aug. 15, 2014, 5:50 p.m. UTC
CONFIG_DEFCONFIG_LIST specifies the default defconfig.
It is used by "make savedefconfig" when .config is missing.
But that's it.  I could not find other useful cases.

As a side effect, CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig"
is contained in .config of every target board, which some people
think is odd.  So, let's remove it.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Michal Simek <michal.simek@xilinx.com>
---

 Kconfig | 6 ------
 1 file changed, 6 deletions(-)

Comments

Michal Simek Aug. 19, 2014, 6:51 a.m. UTC | #1
On 08/15/2014 07:50 PM, Masahiro Yamada wrote:
> CONFIG_DEFCONFIG_LIST specifies the default defconfig.
> It is used by "make savedefconfig" when .config is missing.
> But that's it.  I could not find other useful cases.
> 
> As a side effect, CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig"
> is contained in .config of every target board, which some people
> think is odd.  So, let's remove it.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> ---

Great.

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal
Tom Rini Aug. 23, 2014, 12:42 p.m. UTC | #2
On Sat, Aug 16, 2014 at 02:50:12AM +0900, Masahiro Yamada wrote:

> CONFIG_DEFCONFIG_LIST specifies the default defconfig.
> It is used by "make savedefconfig" when .config is missing.
> But that's it.  I could not find other useful cases.
> 
> As a side effect, CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig"
> is contained in .config of every target board, which some people
> think is odd.  So, let's remove it.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/Kconfig b/Kconfig
index 9e77a6e..1a38645 100644
--- a/Kconfig
+++ b/Kconfig
@@ -12,12 +12,6 @@  config KCONFIG_OBJDIR
 	string
 	option env="KCONFIG_OBJDIR"
 
-config DEFCONFIG_LIST
-	string
-	depends on !SPL_BUILD
-	option defconfig_list
-	default "configs/sandbox_defconfig"
-
 menu "General setup"
 
 config SPL_BUILD