| Message ID | 1407998707-9632-3-git-send-email-b18965@freescale.com |
|---|---|
| State | Superseded |
| Headers | show |
On 08/13/2014 11:44 PM, Alison Wang wrote: > This patch is to add I2C 1,2,3 support for LS102xA. > I think the commit message should say which existing I2C driver is compatible with the controller of LS201x. From the change, you are using the same driver for i.MX. But it is not clear if you are using the 8-bit driver or the 32-bit driver. I can tell from your patch 01/18 that you enabled I2C_QUIRK_REG to use 8-bit driver. This should go into the commit message to help other follow the suit if another SoC is added the same way. York
On 08/13/2014 11:44 PM, Alison Wang wrote: > This patch is to add I2C 1,2,3 support for LS102xA. > I think the commit message should say which existing I2C driver is compatible with the controller of LS201x. From the change, you are using the same driver for i.MX. But it is not clear if you are using the 8-bit driver or the 32-bit driver. I can tell from your patch 01/18 that you enabled I2C_QUIRK_REG to use 8-bit driver. This should go into the commit message to help other follow the suit if another SoC is added the same way. [Alison Wang] Yes, I will give a detailed commit message. Thanks. Alison -- View this message in context: http://u-boot.10912.n7.nabble.com/PATCH-v4-0-18-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp186703p186809.html Sent from the U-Boot mailing list archive at Nabble.com.
diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c index c14797c..83a9ffa 100644 --- a/drivers/i2c/mxc_i2c.c +++ b/drivers/i2c/mxc_i2c.c @@ -423,7 +423,7 @@ static void * const i2c_bases[] = { (void *)IMX_I2C2_BASE #elif defined(CONFIG_MX31) || defined(CONFIG_MX35) || \ defined(CONFIG_MX51) || defined(CONFIG_MX53) || \ - defined(CONFIG_MX6) + defined(CONFIG_MX6) || defined(CONFIG_LS102xA) (void *)I2C1_BASE_ADDR, (void *)I2C2_BASE_ADDR, (void *)I2C3_BASE_ADDR @@ -545,7 +545,7 @@ U_BOOT_I2C_ADAP_COMPLETE(mxc1, mxc_i2c_init, mxc_i2c_probe, CONFIG_SYS_MXC_I2C2_SLAVE, 1) #if defined(CONFIG_MX31) || defined(CONFIG_MX35) ||\ defined(CONFIG_MX51) || defined(CONFIG_MX53) ||\ - defined(CONFIG_MX6) + defined(CONFIG_MX6) || defined(CONFIG_LS102xA) U_BOOT_I2C_ADAP_COMPLETE(mxc2, mxc_i2c_init, mxc_i2c_probe, mxc_i2c_read, mxc_i2c_write, mxc_i2c_set_bus_speed,
This patch is to add I2C 1,2,3 support for LS102xA. Signed-off-by: Alison Wang <alison.wang@freescale.com> --- Change log: v4: Add commit messages. v3: Add I2C 3 support. v2: No change. drivers/i2c/mxc_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)