| Message ID | 1407748628-7824-1-git-send-email-hs@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
On 11 August 2014 03:17, Heiko Schocher <hs@denx.de> wrote: > currently the buffer for command name is 50 bytes only. If using > fit_info with long absolute paths, this is not enough, so raise > it to 256 (as it is in fit_check_sign) > > Signed-off-by: Heiko Schocher <hs@denx.de> > Cc: Simon Glass <sjg@chromium.org> Acked-by: Simon Glass <sjg@chromium.org> > --- > tools/fit_info.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/fit_info.c b/tools/fit_info.c > index 481ac6d..652abcd 100644 > --- a/tools/fit_info.c > +++ b/tools/fit_info.c > @@ -48,10 +48,11 @@ int main(int argc, char **argv) > char *fdtfile = NULL; > char *nodename = NULL; > char *propertyname = NULL; > - char cmdname[50]; > + char cmdname[256]; > int c; > > - strcpy(cmdname, *argv); > + strncpy(cmdname, *argv, sizeof(cmdname) - 1); > + cmdname[sizeof(cmdname) - 1] = '\0'; > while ((c = getopt(argc, argv, "f:n:p:")) != -1) > switch (c) { > case 'f': > -- > 1.8.3.1 >
On Mon, 11 Aug 2014 11:17:08 +0200 Heiko Schocher <hs@denx.de> wrote: > currently the buffer for command name is 50 bytes only. If using > fit_info with long absolute paths, this is not enough, so raise > it to 256 (as it is in fit_check_sign) > > Signed-off-by: Heiko Schocher <hs@denx.de> > Cc: Simon Glass <sjg@chromium.org> > --- > tools/fit_info.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) applied to u-boot-staging/agust@denx.de. thanks! Anatolij
diff --git a/tools/fit_info.c b/tools/fit_info.c index 481ac6d..652abcd 100644 --- a/tools/fit_info.c +++ b/tools/fit_info.c @@ -48,10 +48,11 @@ int main(int argc, char **argv) char *fdtfile = NULL; char *nodename = NULL; char *propertyname = NULL; - char cmdname[50]; + char cmdname[256]; int c; - strcpy(cmdname, *argv); + strncpy(cmdname, *argv, sizeof(cmdname) - 1); + cmdname[sizeof(cmdname) - 1] = '\0'; while ((c = getopt(argc, argv, "f:n:p:")) != -1) switch (c) { case 'f':
currently the buffer for command name is 50 bytes only. If using fit_info with long absolute paths, this is not enough, so raise it to 256 (as it is in fit_check_sign) Signed-off-by: Heiko Schocher <hs@denx.de> Cc: Simon Glass <sjg@chromium.org> --- tools/fit_info.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)