| Message ID | 1406288841-23140-1-git-send-email-m.olbrich@pengutronix.de |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Jul 25, 2014 at 8:47 PM, Michael Olbrich <m.olbrich@pengutronix.de> wrote: > Since 257462dbf3ed ("pwm-backlight: switch to gpiod interface") > enable_gpio is no longer set and remains 0 when probing from > device-tree. This is a valid gpio number. With no enable-gpios > specified in the device-tree this is used and probing fails > with: > > pwm-backlight lcd-backlight.3: failed to request GPIO#0: -16 > > Fix this by setting enable_gpio to -1 which is not a valid gpio > number. Looks good indeed. My bad for overlooking this. Acked-by: Alexandre Courbot <acourbot@nvidia.com> > > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de> > --- > > Sorry, I sent the wrong version. This one actually compiles. > > Michael > > drivers/video/backlight/pwm_bl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index 38ca88b..e7e43cd 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -211,6 +211,7 @@ static int pwm_backlight_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "failed to find platform data\n"); > return ret; > } > + defdata.enable_gpio = -1; > > data = &defdata; > } > -- > 2.0.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 38ca88b..e7e43cd 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -211,6 +211,7 @@ static int pwm_backlight_probe(struct platform_device *pdev) dev_err(&pdev->dev, "failed to find platform data\n"); return ret; } + defdata.enable_gpio = -1; data = &defdata; }
Since 257462dbf3ed ("pwm-backlight: switch to gpiod interface") enable_gpio is no longer set and remains 0 when probing from device-tree. This is a valid gpio number. With no enable-gpios specified in the device-tree this is used and probing fails with: pwm-backlight lcd-backlight.3: failed to request GPIO#0: -16 Fix this by setting enable_gpio to -1 which is not a valid gpio number. Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de> --- Sorry, I sent the wrong version. This one actually compiles. Michael drivers/video/backlight/pwm_bl.c | 1 + 1 file changed, 1 insertion(+)