diff mbox

[U-Boot] board_r: Add missing return to initr_doc

Message ID 1405966870-27870-1-git-send-email-ijc@hellion.org.uk
State Changes Requested
Delegated to: Ian Campbell
Headers show

Commit Message

Ian Campbell July 21, 2014, 6:21 p.m. UTC 
I happened to spot this while working in the area.

Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Simon Glass <sjg@chromium.org>
---
 common/board_r.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass July 23, 2014, 10:28 a.m. UTC | #1 
On 21 July 2014 12:21, Ian Campbell <ijc@hellion.org.uk> wrote:
> I happened to spot this while working in the area.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Simon Glass <sjg@chromium.org>

Acked-by: Simon Glass <sjg@chromium.org>

(we normally add a blank line before return but I don't think it is universal)
Nobuhiro Iwamatsu July 23, 2014, 10:18 p.m. UTC | #2 
Hi,

2014-07-22 3:21 GMT+09:00 Ian Campbell <ijc@hellion.org.uk>:
> I happened to spot this while working in the area.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  common/board_r.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/common/board_r.c b/common/board_r.c
> index 4479acb..427ee67 100644
> --- a/common/board_r.c
> +++ b/common/board_r.c
> @@ -600,6 +600,7 @@ static int initr_doc(void)
>  {
>         puts("DOC:   ");
>         doc_init();
> +       return 0

you forgot ';'.


>  }
>  #endif
>
> --
> 2.0.1

Best regards,
  Nobuhiro
Ian Campbell July 24, 2014, 8:28 a.m. UTC | #3 
On Thu, 2014-07-24 at 07:18 +0900, Nobuhiro Iwamatsu wrote:
> Hi,
> 
> 2014-07-22 3:21 GMT+09:00 Ian Campbell <ijc@hellion.org.uk>:
> > I happened to spot this while working in the area.
> >
> > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > Cc: Simon Glass <sjg@chromium.org>
> > ---
> >  common/board_r.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/common/board_r.c b/common/board_r.c
> > index 4479acb..427ee67 100644
> > --- a/common/board_r.c
> > +++ b/common/board_r.c
> > @@ -600,6 +600,7 @@ static int initr_doc(void)
> >  {
> >         puts("DOC:   ");
> >         doc_init();
> > +       return 0
> 
> you forgot ';'.

Gah! v2 coming up...

Ian.
diff mbox

Patch

diff --git a/common/board_r.c b/common/board_r.c
index 4479acb..427ee67 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -600,6 +600,7 @@  static int initr_doc(void)
 {
 	puts("DOC:   ");
 	doc_init();
+	return 0
 }
 #endif