Patchwork [U-Boot] dm: add missing includes

login
register
mail settings
Submitter Jeroen Hofstee
Date June 25, 2014, 7:57 p.m.
Message ID <1403726265-19658-1-git-send-email-jeroen@myspectrum.nl>
Download mbox | patch
Permalink /patch/364140/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Jeroen Hofstee - June 25, 2014, 7:57 p.m.
lists.c / root.c do not include their own header and they
could potentially implement a different function. Therefore
actually include the headers.

cc: sjg@chromium.org
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
 drivers/core/lists.c | 1 +
 drivers/core/root.c  | 1 +
 2 files changed, 2 insertions(+)
Simon Glass - June 26, 2014, 2:15 a.m.
On 25 June 2014 13:57, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
> lists.c / root.c do not include their own header and they
> could potentially implement a different function. Therefore
> actually include the headers.
>
> cc: sjg@chromium.org
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Acked-by: Simon Glass <sjg@chromium.org>
Tom Rini - July 21, 2014, 8:42 p.m.
On Wed, Jun 25, 2014 at 09:57:45PM +0200, Jeroen Hofstee wrote:

> lists.c / root.c do not include their own header and they
> could potentially implement a different function. Therefore
> actually include the headers.
> 
> cc: sjg@chromium.org
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

Patch

diff --git a/drivers/core/lists.c b/drivers/core/lists.c
index afb59d1..87164a5 100644
--- a/drivers/core/lists.c
+++ b/drivers/core/lists.c
@@ -11,6 +11,7 @@ 
 #include <errno.h>
 #include <dm/device.h>
 #include <dm/device-internal.h>
+#include <dm/lists.h>
 #include <dm/platdata.h>
 #include <dm/uclass.h>
 #include <dm/util.h>
diff --git a/drivers/core/root.c b/drivers/core/root.c
index 1cbb096..11e0879 100644
--- a/drivers/core/root.c
+++ b/drivers/core/root.c
@@ -15,6 +15,7 @@ 
 #include <dm/device-internal.h>
 #include <dm/lists.h>
 #include <dm/platdata.h>
+#include <dm/root.h>
 #include <dm/uclass.h>
 #include <dm/util.h>
 #include <linux/list.h>