diff mbox

[U-Boot] mx6sabresd: Disable PCI driver

Message ID 1403283628-6542-1-git-send-email-festevam@gmail.com
State Rejected
Delegated to: Marek Vasut
Headers show

Commit Message

Fabio Estevam June 20, 2014, 5 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

Currently we have a kernel hang when U-boot PCI driver is enabled.

Disable it until a better solution is found.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx6sabresd.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Marek Vasut June 20, 2014, 9:41 p.m. UTC | #1 
On Friday, June 20, 2014 at 07:00:28 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Currently we have a kernel hang when U-boot PCI driver is enabled.
> 
> Disable it until a better solution is found.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

This looks like solving a bug on a wrong end. It is the kernel that needs to be 
fixed, not U-Boot.

Best regards,
Marek Vasut
Fabio Estevam June 21, 2014, 2 p.m. UTC | #2 
On Fri, Jun 20, 2014 at 6:41 PM, Marek Vasut <marex@denx.de> wrote:
> On Friday, June 20, 2014 at 07:00:28 PM, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Currently we have a kernel hang when U-boot PCI driver is enabled.
>>
>> Disable it until a better solution is found.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> This looks like solving a bug on a wrong end. It is the kernel that needs to be
> fixed, not U-Boot.

Since there is no fix in the kernel I prefer to remove this from
U-boot from the time being to avoid the kernel hang.
Jeroen Hofstee June 21, 2014, 8:38 p.m. UTC | #3 
On za, 2014-06-21 at 11:00 -0300, Fabio Estevam wrote:
> On Fri, Jun 20, 2014 at 6:41 PM, Marek Vasut <marex@denx.de> wrote:
> > On Friday, June 20, 2014 at 07:00:28 PM, Fabio Estevam wrote:
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Currently we have a kernel hang when U-boot PCI driver is enabled.
> >>
> >> Disable it until a better solution is found.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > This looks like solving a bug on a wrong end. It is the kernel that needs to be
> > fixed, not U-Boot.
> 
> Since there is no fix in the kernel I prefer to remove this from
> U-boot from the time being to avoid the kernel hang.

this sounds evil, just fix/workaround it in your linux version.

Regards,
Jeroen
diff mbox

Patch

diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h
index e666ebb..d227f44 100644
--- a/include/configs/mx6sabresd.h
+++ b/include/configs/mx6sabresd.h
@@ -49,7 +49,6 @@ 
 #define CONFIG_IMX_HDMI
 #define CONFIG_IMX_VIDEO_SKIP
 
-#define CONFIG_CMD_PCI
 #ifdef CONFIG_CMD_PCI
 #define CONFIG_PCI
 #define CONFIG_PCI_PNP