diff mbox

support: graph-depends requires Python 2

Message ID 1403206215-5562-1-git-send-email-vivien.didelot@savoirfairelinux.com
State Superseded
Headers show

Commit Message

Vivien Didelot June 19, 2014, 7:30 p.m. UTC
Python 3 becomes the default version on some distributions (such as
Archlinux), while they all (Debian, Ubuntu, Arch, Fedora, etc.) define a
python2 symlink for consistency.

Let's specify it in the graph-depends script to make it clear that it
requires the version 2 of Python to work.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 support/scripts/graph-depends | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnout Vandecappelle June 20, 2014, 8:33 p.m. UTC | #1
On 19/06/14 21:30, Vivien Didelot wrote:
> Python 3 becomes the default version on some distributions (such as
> Archlinux), while they all (Debian, Ubuntu, Arch, Fedora, etc.) define a
> python2 symlink for consistency.

 Is that also true for old RHEL? Those beasts offer 10 years of support so you
get really really old ones out there...

 It would be better to just make the script python3-compliant. Probably just a
matter of adding brackets around the print statements -- patch follows.

 Regards,
 Arnout

> 
> Let's specify it in the graph-depends script to make it clear that it
> requires the version 2 of Python to work.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
>  support/scripts/graph-depends | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
> index e2a5e1e..e323e3f 100755
> --- a/support/scripts/graph-depends
> +++ b/support/scripts/graph-depends
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/python2
>  
>  # Usage (the graphviz package must be installed in your distribution)
>  #  ./support/scripts/graph-depends [-p package-name] > test.dot
>
diff mbox

Patch

diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
index e2a5e1e..e323e3f 100755
--- a/support/scripts/graph-depends
+++ b/support/scripts/graph-depends
@@ -1,4 +1,4 @@ 
-#!/usr/bin/python
+#!/usr/bin/python2
 
 # Usage (the graphviz package must be installed in your distribution)
 #  ./support/scripts/graph-depends [-p package-name] > test.dot