| Message ID | 1402312614-13845-2-git-send-email-yamada.m@jp.panasonic.com |
|---|---|
| State | Rejected |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S index d68cc47..fad00da 100644 --- a/arch/arm/lib/vectors.S +++ b/arch/arm/lib/vectors.S @@ -13,6 +13,8 @@ * SPDX-License-Identifier: GPL-2.0+ */ +#include <config.h> + /* ************************************************************************* *
Commit 41623c91 moved exception handling to arch/arm/lib/vectors.S, but it missed to include <config.h>. This mistake causes two problems. [1] "enbw_cmc", "da850evm_direct_nor", "calimain" boards are broken. They expect CONFIG_SYS_DV_NOR_BOOT_CFG (= 0x00000011) at the beginning of the boot image. But it is missing since commit 41623c91 because CONFIG_SYS_DV_NOR_BOOT_CFG is never defined in arch/arm/lib/vectors.S. [2] Boards with CONFIG_USE_IRQ fail with undefined reference error of "IRQ_STACK_START" and "FIQ_STACK_START". This is _potential_ problem because currently there is no board enabling CONFIG_USE_IRQ. But we cannot deny the possibility some board may enable it in future. (If we are not willing to support interrupt feature, all references to CONFIG_USE_IRQ should be dropped immediately.) Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net> --- Changes in v2: - Rephrase commit subject and description. (No change in code-diff) arch/arm/lib/vectors.S | 2 ++ 1 file changed, 2 insertions(+)