| Message ID | 1401981695-3682-1-git-send-email-shreyas@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote: > Build throws following errors when CONFIG_SMP=n > arch/powerpc/platforms/powernv/setup.c: In function ‘pnv_kexec_wait_secondaries_down’: > arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of function ‘get_hard_smp_processor_id’ > rc = opal_query_cpu_status(get_hard_smp_processor_id(i), > > The usage of get_hard_smp_processor_id() needs the declaration from > <asm/smp.h>. The file setup.c includes <linux/sched.h>, which in-turn > includes <linux/smp.h>. However, <linux/smp.h> includes <asm/smp.h> > only on SMP configs and hence UP builds fail. > > Fix this by directly including <asm/smp.h> in setup.c unconditionally. Can you please clean up the description in the commit message ? and also the first line in the commit message should mention that the patch is trying to fix a UP specific build failure.
On Fri, Jun 6, 2014 at 7:33 AM, Anshuman Khandual <khandual@linux.vnet.ibm.com> wrote: > On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote: >> Build throws following errors when CONFIG_SMP=n >> arch/powerpc/platforms/powernv/setup.c: In function ‘pnv_kexec_wait_secondaries_down’: >> arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of function ‘get_hard_smp_processor_id’ >> rc = opal_query_cpu_status(get_hard_smp_processor_id(i), >> >> The usage of get_hard_smp_processor_id() needs the declaration from >> <asm/smp.h>. The file setup.c includes <linux/sched.h>, which in-turn >> includes <linux/smp.h>. However, <linux/smp.h> includes <asm/smp.h> >> only on SMP configs and hence UP builds fail. >> >> Fix this by directly including <asm/smp.h> in setup.c unconditionally. > > Can you please clean up the description in the commit message ? and also > the first line in the commit message should mention that the patch is > trying to fix a UP specific build failure. Both the one-line summary and the first line already mention "UP" or "CONFIG_SMP=n". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, 2014-06-06 at 11:03 +0530, Anshuman Khandual wrote: > On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote: > > Build throws following errors when CONFIG_SMP=n > > arch/powerpc/platforms/powernv/setup.c: In function ‘pnv_kexec_wait_secondaries_down’: > > arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of function ‘get_hard_smp_processor_id’ > > rc = opal_query_cpu_status(get_hard_smp_processor_id(i), > > > > The usage of get_hard_smp_processor_id() needs the declaration from > > <asm/smp.h>. The file setup.c includes <linux/sched.h>, which in-turn > > includes <linux/smp.h>. However, <linux/smp.h> includes <asm/smp.h> > > only on SMP configs and hence UP builds fail. > > > > Fix this by directly including <asm/smp.h> in setup.c unconditionally. > > Can you please clean up the description in the commit message ? and also > the first line in the commit message should mention that the patch is > trying to fix a UP specific build failure. I don't understand your comment ... the description and subject line are perfectly fine... Ben.
diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c index 8c16a5f..678573c 100644 --- a/arch/powerpc/platforms/powernv/setup.c +++ b/arch/powerpc/platforms/powernv/setup.c @@ -35,6 +35,7 @@ #include <asm/rtas.h> #include <asm/opal.h> #include <asm/kexec.h> +#include <asm/smp.h> #include "powernv.h"
Build throws following errors when CONFIG_SMP=n arch/powerpc/platforms/powernv/setup.c: In function ‘pnv_kexec_wait_secondaries_down’: arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of function ‘get_hard_smp_processor_id’ rc = opal_query_cpu_status(get_hard_smp_processor_id(i), The usage of get_hard_smp_processor_id() needs the declaration from <asm/smp.h>. The file setup.c includes <linux/sched.h>, which in-turn includes <linux/smp.h>. However, <linux/smp.h> includes <asm/smp.h> only on SMP configs and hence UP builds fail. Fix this by directly including <asm/smp.h> in setup.c unconditionally. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com> --- arch/powerpc/platforms/powernv/setup.c | 1 + 1 file changed, 1 insertion(+)