diff mbox

[U-Boot,v2] fs: fatwrite: use map_sysmem before use file_fat_write

Message ID 1401850884-4265-1-git-send-email-josh.wu@atmel.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Josh Wu June 4, 2014, 3:01 a.m. UTC
When the map_sysmem, then the fatwrite command can support sandbox.
Following command will show how to use it:
  => sb bind 0 sd.img
  => fatls host 0
  => fatwrite host 0 $memaddr filename $filesize

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
v1 -> v2:
  remove the type cast for the addr.

 common/cmd_fat.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Simon Glass June 4, 2014, 3:16 a.m. UTC | #1
On 3 June 2014 21:01, Josh Wu <josh.wu@atmel.com> wrote:
> When the map_sysmem, then the fatwrite command can support sandbox.
> Following command will show how to use it:
>   => sb bind 0 sd.img
>   => fatls host 0
>   => fatwrite host 0 $memaddr filename $filesize
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>

Acked-by: Simon Glass <sjg@chromium.org>
Tom Rini June 5, 2014, 10:49 p.m. UTC | #2
On Wed, Jun 04, 2014 at 11:01:24AM +0800, Wu, Josh wrote:

> When the map_sysmem, then the fatwrite command can support sandbox.
> Following command will show how to use it:
>   => sb bind 0 sd.img
>   => fatls host 0
>   => fatwrite host 0 $memaddr filename $filesize
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/cmd_fat.c b/common/cmd_fat.c
index a12d8fa..fbe3346 100644
--- a/common/cmd_fat.c
+++ b/common/cmd_fat.c
@@ -13,6 +13,7 @@ 
 #include <s_record.h>
 #include <net.h>
 #include <ata.h>
+#include <asm/io.h>
 #include <part.h>
 #include <fat.h>
 #include <fs.h>
@@ -93,6 +94,7 @@  static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag,
 	disk_partition_t info;
 	int dev = 0;
 	int part = 1;
+	void *buf;
 
 	if (argc < 5)
 		return cmd_usage(cmdtp);
@@ -111,7 +113,9 @@  static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag,
 	addr = simple_strtoul(argv[3], NULL, 16);
 	count = simple_strtoul(argv[5], NULL, 16);
 
-	size = file_fat_write(argv[4], (void *)addr, count);
+	buf = map_sysmem(addr, count);
+	size = file_fat_write(argv[4], buf, count);
+	unmap_sysmem(buf);
 	if (size == -1) {
 		printf("\n** Unable to write \"%s\" from %s %d:%d **\n",
 			argv[4], argv[1], dev, part);