diff mbox

[1/2] mtd/spi: support en25s64 device

Message ID 1400666751-11459-1-git-send-email-Shengzhou.Liu@freescale.com (mailing list archive)
State Superseded
Delegated to: Scott Wood
Headers show

Commit Message

Shengzhou Liu May 21, 2014, 10:05 a.m. UTC
Add support for EON en25s64 spi device.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
---
 drivers/mtd/devices/m25p80.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Scott Wood May 21, 2014, 8:50 p.m. UTC | #1
On Wed, 2014-05-21 at 18:05 +0800, Shengzhou Liu wrote:
> Add support for EON en25s64 spi device.
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> ---
>  drivers/mtd/devices/m25p80.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 7eda71d..6989311 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -745,6 +745,7 @@ static const struct spi_device_id m25p_ids[] = {
>  	{ "en25q32b",   INFO(0x1c3016, 0, 64 * 1024,   64, 0) },
>  	{ "en25p64",    INFO(0x1c2017, 0, 64 * 1024,  128, 0) },
>  	{ "en25q64",    INFO(0x1c3017, 0, 64 * 1024,  128, SECT_4K) },
> +	{ "en25s64",    INFO(0x1c3817, 0, 64 * 1024,  128, 0) },
>  	{ "en25qh256",  INFO(0x1c7019, 0, 64 * 1024,  512, 0) },
>  
>  	/* ESMT */

This needs to be sent to the mtd and/or spi maintainers, not here.

What does this have to do with patch 2/2?  Don't put unrelated things in
the same patchset, especially when they're destined for different
maintainers.

-Scott
Shengzhou Liu May 23, 2014, 8:20 a.m. UTC | #2
> -----Original Message-----

> > --- a/drivers/mtd/devices/m25p80.c

> > +++ b/drivers/mtd/devices/m25p80.c

> > @@ -745,6 +745,7 @@ static const struct spi_device_id m25p_ids[] = {

> >  	{ "en25q32b",   INFO(0x1c3016, 0, 64 * 1024,   64, 0) },

> >  	{ "en25p64",    INFO(0x1c2017, 0, 64 * 1024,  128, 0) },

> >  	{ "en25q64",    INFO(0x1c3017, 0, 64 * 1024,  128, SECT_4K) },

> > +	{ "en25s64",    INFO(0x1c3817, 0, 64 * 1024,  128, 0) },

> >  	{ "en25qh256",  INFO(0x1c7019, 0, 64 * 1024,  512, 0) },

> >

> >  	/* ESMT */

> 

> This needs to be sent to the mtd and/or spi maintainers, not here.

> 

> What does this have to do with patch 2/2?  Don't put unrelated things in

> the same patchset, especially when they're destined for different

> maintainers.

> 

> -Scott

> 

[Shengzhou] thanks, sent to linux-mtd@lists.infradead.org already.
diff mbox

Patch

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 7eda71d..6989311 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -745,6 +745,7 @@  static const struct spi_device_id m25p_ids[] = {
 	{ "en25q32b",   INFO(0x1c3016, 0, 64 * 1024,   64, 0) },
 	{ "en25p64",    INFO(0x1c2017, 0, 64 * 1024,  128, 0) },
 	{ "en25q64",    INFO(0x1c3017, 0, 64 * 1024,  128, SECT_4K) },
+	{ "en25s64",    INFO(0x1c3817, 0, 64 * 1024,  128, 0) },
 	{ "en25qh256",  INFO(0x1c7019, 0, 64 * 1024,  512, 0) },
 
 	/* ESMT */