| Message ID | 1398344677-11130-1-git-send-email-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
Il 24/04/2014 15:04, Andreas Färber ha scritto: > Invented by Anthony. Maintained through my qom-next tree lately. > > Cc: Anthony Liguori <aliguori@amazon.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > MAINTAINERS | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c66946f..87a56b7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -778,6 +778,16 @@ S: Supported > F: qapi-schema.json > T: git git://repo.or.cz/qemu/qmp-unstable.git queue/qmp > > +QOM > +M: Anthony Liguori <aliguori@amazon.com> > +M: Andreas Färber <afaerber@suse.de> > +S: Supported > +T: git git://github.com/afaerber/qemu-cpu.git qom-next > +F: include/qom/object.h > +F: qom/object.c > +F: qom/container.c > +F: tests/qom-test.c > + > QMP > M: Luiz Capitulino <lcapitulino@redhat.com> > S: Maintained > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
On 24 April 2014 14:04, Andreas Färber <afaerber@suse.de> wrote: > Invented by Anthony. Maintained through my qom-next tree lately. > > Cc: Anthony Liguori <aliguori@amazon.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> Acked-by: Peter Maydell <peter.maydell@linaro.org> Are you going to put this in your qom tree or did you want me to apply it directly? thanks -- PMM
Am 28.04.2014 19:03, schrieb Peter Maydell: > On 24 April 2014 14:04, Andreas Färber <afaerber@suse.de> wrote: >> Invented by Anthony. Maintained through my qom-next tree lately. >> >> Cc: Anthony Liguori <aliguori@amazon.com> >> Cc: Paolo Bonzini <pbonzini@redhat.com> >> Signed-off-by: Andreas Färber <afaerber@suse.de> > > Acked-by: Peter Maydell <peter.maydell@linaro.org> > > Are you going to put this in your qom tree or did > you want me to apply it directly? Thanks. Via qom-next, as indicated as tag. Andreas
Am 28.04.2014 11:04, schrieb Paolo Bonzini: > Il 24/04/2014 15:04, Andreas Färber ha scritto: >> Invented by Anthony. Maintained through my qom-next tree lately. >> >> Cc: Anthony Liguori <aliguori@amazon.com> >> Cc: Paolo Bonzini <pbonzini@redhat.com> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> MAINTAINERS | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index c66946f..87a56b7 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -778,6 +778,16 @@ S: Supported >> F: qapi-schema.json >> T: git git://repo.or.cz/qemu/qmp-unstable.git queue/qmp >> >> +QOM >> +M: Anthony Liguori <aliguori@amazon.com> >> +M: Andreas Färber <afaerber@suse.de> >> +S: Supported >> +T: git git://github.com/afaerber/qemu-cpu.git qom-next >> +F: include/qom/object.h >> +F: qom/object.c >> +F: qom/container.c >> +F: tests/qom-test.c >> + >> QMP >> M: Luiz Capitulino <lcapitulino@redhat.com> >> S: Maintained >> > > Acked-by: Paolo Bonzini <pbonzini@redhat.com> Thanks. Note that I have excluded qom-qobject.[hc] here, which I have never touched or reviewed and carries your authorship. Maybe add it to the QAPI entry? object_interfaces.c has neither license header nor copyright, wasn't involved in that either. And if you wanted to be listed as third M: (vacation fallback or just additional patch reviewer), I would happily add you - I usually CC you on potentially controversial changes anyway. :) Cheers, Andreas
Il 28/04/2014 20:07, Andreas Färber ha scritto: >> > Acked-by: Paolo Bonzini <pbonzini@redhat.com> > Thanks. Note that I have excluded qom-qobject.[hc] here, which I have > never touched or reviewed and carries your authorship. Maybe add it to > the QAPI entry? > > object_interfaces.c has neither license header nor copyright, wasn't > involved in that either. I think both of them can be added to here, at least qom-qobject.c. > And if you wanted to be listed as third M: (vacation fallback or just > additional patch reviewer), I would happily add you - I usually CC you > on potentially controversial changes anyway. :) Being CCed is enough, vacation fallbacks need not be formalized in MAINTAINERS. Paolo
Am 28.04.2014 21:11, schrieb Paolo Bonzini: > Il 28/04/2014 20:07, Andreas Färber ha scritto: >>> > Acked-by: Paolo Bonzini <pbonzini@redhat.com> >> Thanks. Note that I have excluded qom-qobject.[hc] here, which I have >> never touched or reviewed and carries your authorship. Maybe add it to >> the QAPI entry? >> >> object_interfaces.c has neither license header nor copyright, wasn't >> involved in that either. > > I think both of them can be added to here, at least qom-qobject.c. The alternative would then be to just use: F: include/qom/ X: include/qom/cpu.h F: qom/ X: qom/cpu.c Opinions? Andreas
Il 28/04/2014 21:29, Andreas Färber ha scritto: > Am 28.04.2014 21:11, schrieb Paolo Bonzini: >> Il 28/04/2014 20:07, Andreas Färber ha scritto: >>>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com> >>> Thanks. Note that I have excluded qom-qobject.[hc] here, which I have >>> never touched or reviewed and carries your authorship. Maybe add it to >>> the QAPI entry? >>> >>> object_interfaces.c has neither license header nor copyright, wasn't >>> involved in that either. >> >> I think both of them can be added to here, at least qom-qobject.c. > > The alternative would then be to just use: > > F: include/qom/ > X: include/qom/cpu.h > F: qom/ > X: qom/cpu.c > > Opinions? Didn't know about "X:", good idea. Paolo
diff --git a/MAINTAINERS b/MAINTAINERS index c66946f..87a56b7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -778,6 +778,16 @@ S: Supported F: qapi-schema.json T: git git://repo.or.cz/qemu/qmp-unstable.git queue/qmp +QOM +M: Anthony Liguori <aliguori@amazon.com> +M: Andreas Färber <afaerber@suse.de> +S: Supported +T: git git://github.com/afaerber/qemu-cpu.git qom-next +F: include/qom/object.h +F: qom/object.c +F: qom/container.c +F: tests/qom-test.c + QMP M: Luiz Capitulino <lcapitulino@redhat.com> S: Maintained
Invented by Anthony. Maintained through my qom-next tree lately. Cc: Anthony Liguori <aliguori@amazon.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Andreas Färber <afaerber@suse.de> --- MAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)