| Message ID | 1398309907-9285-1-git-send-email-badarkhe.manish@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Tom, On Thu, Apr 24, 2014 at 8:55 AM, Manish Badarkhe <badarkhe.manish@gmail.com> wrote: > Make funtions static which are locally used in file. > > Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com> > --- > :100644 100644 704c243... d29d969... M drivers/power/tps6586x.c > drivers/power/tps6586x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/tps6586x.c b/drivers/power/tps6586x.c > index 704c243..d29d969 100644 > --- a/drivers/power/tps6586x.c > +++ b/drivers/power/tps6586x.c > @@ -32,7 +32,7 @@ enum { > }; > > #define MAX_I2C_RETRY 3 > -int tps6586x_read(int reg) > +static int tps6586x_read(int reg) > { > int i; > uchar data; > @@ -61,7 +61,7 @@ exit: > return retval; > } > > -int tps6586x_write(int reg, uchar *data, uint len) > +static int tps6586x_write(int reg, uchar *data, uint len) > { > int i; > int retval = -1; > -- > 1.7.10.4 > Please provide your comments on this patch. Thanks Manish Badarkhe
On Thu, Apr 24, 2014 at 08:55:07AM +0530, Manish Badarkhe wrote: > Make funtions static which are locally used in file. > > Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com> Applied to u-boot/master, thanks!
diff --git a/drivers/power/tps6586x.c b/drivers/power/tps6586x.c index 704c243..d29d969 100644 --- a/drivers/power/tps6586x.c +++ b/drivers/power/tps6586x.c @@ -32,7 +32,7 @@ enum { }; #define MAX_I2C_RETRY 3 -int tps6586x_read(int reg) +static int tps6586x_read(int reg) { int i; uchar data; @@ -61,7 +61,7 @@ exit: return retval; } -int tps6586x_write(int reg, uchar *data, uint len) +static int tps6586x_write(int reg, uchar *data, uint len) { int i; int retval = -1;
Make funtions static which are locally used in file. Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com> --- :100644 100644 704c243... d29d969... M drivers/power/tps6586x.c drivers/power/tps6586x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)