| Message ID | 1397046357-12804-1-git-send-email-trini@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Dear Tom Rini, In message <1397046357-12804-1-git-send-email-trini@ti.com> you wrote: > In the case of SPL or NOR_BOOT (no SPL involved) we need to include > certain code in the build. Use !CONFIG_SKIP_LOWLEVEL_INIT rather than > CONFIG_SPL_BUILD || CONFIG_NOR_BOOT to make the code clearer, and to > make supporting XIP QSPI boot clearer in the code. > > Signed-off-by: Tom Rini <trini@ti.com> > --- > arch/arm/cpu/armv7/am33xx/board.c | 4 +--- > arch/arm/cpu/armv7/am33xx/emif4.c | 2 +- > board/silica/pengwyn/Makefile | 2 +- > board/ti/am335x/Makefile | 2 +- > board/ti/am335x/board.c | 2 +- > 5 files changed, 5 insertions(+), 7 deletions(-) Reviewed-by: Wolfgang Denk <wd@denx.de> Best regards, Wolfgang Denk
On Wed, Apr 09, 2014 at 08:25:57AM -0400, Tom Rini wrote: > In the case of SPL or NOR_BOOT (no SPL involved) we need to include > certain code in the build. Use !CONFIG_SKIP_LOWLEVEL_INIT rather than > CONFIG_SPL_BUILD || CONFIG_NOR_BOOT to make the code clearer, and to > make supporting XIP QSPI boot clearer in the code. > > Signed-off-by: Tom Rini <trini@ti.com> > Reviewed-by: Wolfgang Denk <wd@denx.de> Applied to u-boot-ti/master, thanks!
diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c index fb44cc8..28c16f8 100644 --- a/arch/arm/cpu/armv7/am33xx/board.c +++ b/arch/arm/cpu/armv7/am33xx/board.c @@ -142,7 +142,7 @@ int arch_misc_init(void) return 0; } -#if defined(CONFIG_SPL_BUILD) || defined(CONFIG_NOR_BOOT) +#ifndef CONFIG_SKIP_LOWLEVEL_INIT /* * This function is the place to do per-board things such as ramp up the * MPU clock frequency. @@ -200,9 +200,7 @@ static void watchdog_disable(void) while (readl(&wdtimer->wdtwwps) != 0x0) ; } -#endif -#if defined(CONFIG_SPL_BUILD) || defined(CONFIG_NOR_BOOT) void s_init(void) { /* diff --git a/arch/arm/cpu/armv7/am33xx/emif4.c b/arch/arm/cpu/armv7/am33xx/emif4.c index 3e39752..2c67c32 100644 --- a/arch/arm/cpu/armv7/am33xx/emif4.c +++ b/arch/arm/cpu/armv7/am33xx/emif4.c @@ -35,7 +35,7 @@ void dram_init_banksize(void) } -#if defined(CONFIG_SPL_BUILD) || defined(CONFIG_NOR_BOOT) +#ifndef CONFIG_SKIP_LOWLEVEL_INIT #ifdef CONFIG_TI81XX static struct dmm_lisa_map_regs *hw_lisa_map_regs = (struct dmm_lisa_map_regs *)DMM_BASE; diff --git a/board/silica/pengwyn/Makefile b/board/silica/pengwyn/Makefile index c8b4f9a..804ac37 100644 --- a/board/silica/pengwyn/Makefile +++ b/board/silica/pengwyn/Makefile @@ -6,7 +6,7 @@ # SPDX-License-Identifier: GPL-2.0+ # -ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_NOR_BOOT),y) +ifeq ($(CONFIG_SKIP_LOWLEVEL_INIT),) obj-y := mux.o endif diff --git a/board/ti/am335x/Makefile b/board/ti/am335x/Makefile index c8b4f9a..804ac37 100644 --- a/board/ti/am335x/Makefile +++ b/board/ti/am335x/Makefile @@ -6,7 +6,7 @@ # SPDX-License-Identifier: GPL-2.0+ # -ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_NOR_BOOT),y) +ifeq ($(CONFIG_SKIP_LOWLEVEL_INIT),) obj-y := mux.o endif diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c index 554398f..fe1d000 100644 --- a/board/ti/am335x/board.c +++ b/board/ti/am335x/board.c @@ -81,7 +81,7 @@ static int read_eeprom(struct am335x_baseboard_id *header) return 0; } -#if defined(CONFIG_SPL_BUILD) || defined(CONFIG_NOR_BOOT) +#ifndef CONFIG_SKIP_LOWLEVEL_INIT static const struct ddr_data ddr2_data = { .datardsratio0 = ((MT47H128M16RT25E_RD_DQS<<30) | (MT47H128M16RT25E_RD_DQS<<20) |
In the case of SPL or NOR_BOOT (no SPL involved) we need to include certain code in the build. Use !CONFIG_SKIP_LOWLEVEL_INIT rather than CONFIG_SPL_BUILD || CONFIG_NOR_BOOT to make the code clearer, and to make supporting XIP QSPI boot clearer in the code. Signed-off-by: Tom Rini <trini@ti.com> --- arch/arm/cpu/armv7/am33xx/board.c | 4 +--- arch/arm/cpu/armv7/am33xx/emif4.c | 2 +- board/silica/pengwyn/Makefile | 2 +- board/ti/am335x/Makefile | 2 +- board/ti/am335x/board.c | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-)