diff mbox

[U-Boot] omap3: igep00x0: fix NAND_BOOT for igep_0020 and igep_0030

Message ID 1396508966-9407-1-git-send-email-pekon@ti.com
State Not Applicable
Headers show

Commit Message

pekon gupta April 3, 2014, 7:09 a.m. UTC
fixes commit e37e954eba3edb5015a0a02880d57517f57425d8
    OMAP3: igep00x0: Convert to ti_omap3_common.h.

Above commit introduced compilation error when building igep0020 and igep0030
boards for NAND boot. It removed 'CONFIG_SYS_NAND_U_BOOT_START' which tells
SPL/MLO offset of u-boot.img in NAND.

Signed-off-by: Pekon Gupta <pekon@ti.com>
---
 include/configs/omap3_igep00x0.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Enric Balletbo Serra April 3, 2014, 7:46 a.m. UTC | #1
Hi Peko

2014-04-03 9:09 GMT+02:00 Pekon Gupta <pekon@ti.com>:
> fixes commit e37e954eba3edb5015a0a02880d57517f57425d8
>     OMAP3: igep00x0: Convert to ti_omap3_common.h.
>
> Above commit introduced compilation error when building igep0020 and igep0030
> boards for NAND boot. It removed 'CONFIG_SYS_NAND_U_BOOT_START' which tells
> SPL/MLO offset of u-boot.img in NAND.
>
> Signed-off-by: Pekon Gupta <pekon@ti.com>
> ---
>  include/configs/omap3_igep00x0.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/omap3_igep00x0.h b/include/configs/omap3_igep00x0.h
> index 8b8583a..4e87d6b 100644
> --- a/include/configs/omap3_igep00x0.h
> +++ b/include/configs/omap3_igep00x0.h
> @@ -199,6 +199,8 @@
>  #define CONFIG_SYS_NAND_ECCSIZE                512
>  #define CONFIG_SYS_NAND_ECCBYTES       3
>  #define CONFIG_NAND_OMAP_ECCSCHEME     OMAP_ECC_HAM1_CODE_HW
> +#define CONFIG_SYS_NAND_U_BOOT_START   CONFIG_SYS_TEXT_BASE
> +#define CONFIG_SYS_NAND_U_BOOT_OFFS    0x80000


These two defines are defined in ti_armv7_common.h. The
ti_armv7_common.h is included by ti_omap3_common.h, and
omap3_igep00x0.h includes this file. So should not be necessary define
this. I tried to build current mainline using igep0020_nand_config and
built without errors for me. Which branch are you using ?

>  #endif
>
>  #endif /* __IGEP00X0_H */
> --
> 1.8.5.1.163.gd7aced9
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/include/configs/omap3_igep00x0.h b/include/configs/omap3_igep00x0.h
index 8b8583a..4e87d6b 100644
--- a/include/configs/omap3_igep00x0.h
+++ b/include/configs/omap3_igep00x0.h
@@ -199,6 +199,8 @@ 
 #define CONFIG_SYS_NAND_ECCSIZE		512
 #define CONFIG_SYS_NAND_ECCBYTES	3
 #define CONFIG_NAND_OMAP_ECCSCHEME	OMAP_ECC_HAM1_CODE_HW
+#define CONFIG_SYS_NAND_U_BOOT_START	CONFIG_SYS_TEXT_BASE
+#define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
 #endif
 
 #endif /* __IGEP00X0_H */