| Message ID | 1395749346-23642-1-git-send-email-luis.henriques@canonical.com |
|---|---|
| State | New |
| Headers | show |
diff --git a/fs/namei.c b/fs/namei.c index df9946e..b8f1f7f 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3708,6 +3708,7 @@ retry: out_dput: done_path_create(&new_path, new_dentry); if (retry_estale(error, how)) { + path_put(&old_path); how |= LOOKUP_REVAL; goto retry; }
This is a note to let you know that I have just added a patch titled Fix mountpoint reference leakage in linkat to the linux-3.11.y-queue branch of the 3.11.y.z extended stable tree which can be found at: http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.11.y-queue If you, or anyone else, feels it should not be added to this tree, please reply to this email. For more information about the 3.11.y.z tree, see https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable Thanks. -Luis ------ From 7b7d356a86fd99dd3dee5dd8eb3ecf1488eed4f9 Mon Sep 17 00:00:00 2001 From: Oleg Drokin <green@linuxhacker.ru> Date: Fri, 31 Jan 2014 15:41:58 -0500 Subject: Fix mountpoint reference leakage in linkat commit d22e6338db7f613dd4f6095c190682fcc519e4b7 upstream. Recent changes to retry on ESTALE in linkat (commit 442e31ca5a49e398351b2954b51f578353fdf210) introduced a mountpoint reference leak and a small memory leak in case a filesystem link operation returns ESTALE which is pretty normal for distributed filesystems like lustre, nfs and so on. Free old_path in such a case. [AV: there was another missing path_put() nearby - on the previous goto retry] Signed-off-by: Oleg Drokin: <green@linuxhacker.ru> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> [ luis: backported to 3.11: - dropped AV changes as they are not applicable to 3.11 kernel ] Signed-off-by: Luis Henriques <luis.henriques@canonical.com> --- fs/namei.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1