diff mbox

[RFT,for-2.0-rc1] make-release: Record SeaBIOS version

Message ID 1395277315-7806-1-git-send-email-afaerber@suse.de
State New
Headers show

Commit Message

Andreas Färber March 20, 2014, 1:01 a.m. UTC
Before deleting .git, determine the version and save it in .version file.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 scripts/make-release | 1 +
 1 file changed, 1 insertion(+)

Comments

Gerd Hoffmann March 20, 2014, 8:04 a.m. UTC | #1
> +(cd roms/seabios && git describe --tags --long --dirty > .version)
>  rm -rf .git roms/*/.git dtc/.git pixman/.git

Looks good.  Mimics what roms/seabios/scripts/buildversion.sh is doing
in case .git is present.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
  Gerd
Andreas Färber March 25, 2014, 3:31 p.m. UTC | #2
Am 20.03.2014 09:04, schrieb Gerd Hoffmann:
>> +(cd roms/seabios && git describe --tags --long --dirty > .version)
>>  rm -rf .git roms/*/.git dtc/.git pixman/.git
> 
> Looks good.  Mimics what roms/seabios/scripts/buildversion.sh is doing
> in case .git is present.
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Ping! I have meanwhile confirmed that a roms/seabios/.version file with
the expected contents gets included in the tarball with this patch.

Anthony, can you please confirm and use? Thanks!

Regards,
Andreas
Peter Maydell March 31, 2014, 4:40 p.m. UTC | #3
On 25 March 2014 15:31, Andreas Färber <afaerber@suse.de> wrote:
> Am 20.03.2014 09:04, schrieb Gerd Hoffmann:
>>> +(cd roms/seabios && git describe --tags --long --dirty > .version)
>>>  rm -rf .git roms/*/.git dtc/.git pixman/.git
>>
>> Looks good.  Mimics what roms/seabios/scripts/buildversion.sh is doing
>> in case .git is present.
>>
>> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Ping! I have meanwhile confirmed that a roms/seabios/.version file with
> the expected contents gets included in the tarball with this patch.

Applied to master, thanks.

-- PMM
diff mbox

Patch

diff --git a/scripts/make-release b/scripts/make-release
index 186358d..fa6323f 100755
--- a/scripts/make-release
+++ b/scripts/make-release
@@ -18,6 +18,7 @@  git clone "${src}" ${destination}
 pushd ${destination}
 git checkout "v${version}"
 git submodule update --init
+(cd roms/seabios && git describe --tags --long --dirty > .version)
 rm -rf .git roms/*/.git dtc/.git pixman/.git
 popd
 tar cfj ${destination}.tar.bz2 ${destination}