diff mbox

[U-Boot] cmd_nvedit: Make 'env import -c' require size parameter

Message ID 1393966355-9640-1-git-send-email-trini@ti.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Tom Rini March 4, 2014, 8:52 p.m. UTC
When importing a checksummed area we need to be told how big the area in
question is so that we know that will match the size of the area which
the checksum is generated against.

Reported-by: Pierre AUBERT <p.aubert@staubli.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
 common/cmd_nvedit.c |    3 +++
 1 file changed, 3 insertions(+)

Comments

Tom Rini March 7, 2014, 10:29 p.m. UTC | #1
On Tue, Mar 04, 2014 at 03:52:35PM -0500, Tom Rini wrote:

> When importing a checksummed area we need to be told how big the area in
> question is so that we know that will match the size of the area which
> the checksum is generated against.
> 
> Reported-by: Pierre AUBERT <p.aubert@staubli.com>
> Signed-off-by: Tom Rini <trini@ti.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index 5bcc324..c53601c 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -1008,6 +1008,9 @@  static int do_env_import(cmd_tbl_t *cmdtp, int flag,
 
 	if (argc == 2) {
 		size = simple_strtoul(argv[1], NULL, 16);
+	} else if (argc == 1 && chk) {
+		puts("## Error: external checksum format must pass size\n");
+		return CMD_RET_FAILURE;
 	} else {
 		char *s = addr;