| Message ID | 1249b172ff1e3a651955941fe7da32d3644ad2ee.1392571021.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Yann, On Sun, Feb 16, 2014 at 6:27 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Samuel Martin <s.martin49@gmail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Arnout Vandecappelle <arnout@mind.be> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > --- > docs/manual/adding-packages-directory.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt > index 754a145..1917823 100644 > --- a/docs/manual/adding-packages-directory.txt > +++ b/docs/manual/adding-packages-directory.txt > @@ -218,6 +218,12 @@ use in the comment. > ** Dependency symbol: +BR2_USE_MMU+ > ** Comment string: no comment to be added > > +* Kernel headers > +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace s/synbol/symbol/ > + +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) > +** Comment string: `headers >= X.Y` (replace +X.Y+ with the > + proper version) > + > * C library > ** Dependency symbol: +BR2_TOOLCHAIN_USES_GLIBC+, > +BR2_TOOLCHAIN_USES_UCLIBC+ > -- > 1.8.1.2 > Regards,
Samuel, All, On 2014-02-16 18:41 +0100, Samuel Martin spake thusly: > On Sun, Feb 16, 2014 at 6:27 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Cc: Samuel Martin <s.martin49@gmail.com> > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Cc: Arnout Vandecappelle <arnout@mind.be> > > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > > --- > > docs/manual/adding-packages-directory.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt > > index 754a145..1917823 100644 > > --- a/docs/manual/adding-packages-directory.txt > > +++ b/docs/manual/adding-packages-directory.txt > > @@ -218,6 +218,12 @@ use in the comment. > > ** Dependency symbol: +BR2_USE_MMU+ > > ** Comment string: no comment to be added > > > > +* Kernel headers > > +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace > > s/synbol/symbol/ Fixed! Thank you! Regards, Yann E. MORIN.
"Yann E. MORIN" <yann.morin.1998@free.fr> schreef: >From: "Yann E. MORIN" <yann.morin.1998@free.fr> > >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> >Cc: Samuel Martin <s.martin49@gmail.com> >Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >Cc: Arnout Vandecappelle <arnout@mind.be> >Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> >--- > docs/manual/adding-packages-directory.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt >index 754a145..1917823 100644 >--- a/docs/manual/adding-packages-directory.txt >+++ b/docs/manual/adding-packages-directory.txt >@@ -218,6 +218,12 @@ use in the comment. > ** Dependency symbol: +BR2_USE_MMU+ > ** Comment string: no comment to be added > >+* Kernel headers >+** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace >+ +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) >+** Comment string: `headers >= X.Y` (replace +X.Y+ with the >+ proper version) Are these backticks? Is there a specific reason you use this instead of single or double quotes? Best regards, Thomas
Thomas, All, On 2014-02-16 21:03 +0100, Thomas De Schampheleire spake thusly: > "Yann E. MORIN" <yann.morin.1998@free.fr> schreef: > >From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > > >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > >Cc: Samuel Martin <s.martin49@gmail.com> > >Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > >Cc: Arnout Vandecappelle <arnout@mind.be> > >Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > >--- > > docs/manual/adding-packages-directory.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > >diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt > >index 754a145..1917823 100644 > >--- a/docs/manual/adding-packages-directory.txt > >+++ b/docs/manual/adding-packages-directory.txt > >@@ -218,6 +218,12 @@ use in the comment. > > ** Dependency symbol: +BR2_USE_MMU+ > > ** Comment string: no comment to be added > > > >+* Kernel headers > >+** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace > >+ +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) > >+** Comment string: `headers >= X.Y` (replace +X.Y+ with the > >+ proper version) > > Are these backticks? > Is there a specific reason you use this instead of single or double quotes? I just duplicated what wah done for C++, a few lines below. Lookign at the other comments, it looks like C++ is the only one using backticks, the others use the +blabla+ format. Will fix bot before submitting again. Thanks for the review! Regards, Yann E. MORIN.
"Yann E. MORIN" <yann.morin.1998@free.fr> schreef: >Thomas, All, > >On 2014-02-16 21:03 +0100, Thomas De Schampheleire spake thusly: >> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef: >> >From: "Yann E. MORIN" <yann.morin.1998@free.fr> >> > >> >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> >> >Cc: Samuel Martin <s.martin49@gmail.com> >> >Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> >Cc: Arnout Vandecappelle <arnout@mind.be> >> >Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> >> >--- >> > docs/manual/adding-packages-directory.txt | 6 ++++++ >> > 1 file changed, 6 insertions(+) >> > >> >diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt >> >index 754a145..1917823 100644 >> >--- a/docs/manual/adding-packages-directory.txt >> >+++ b/docs/manual/adding-packages-directory.txt >> >@@ -218,6 +218,12 @@ use in the comment. >> > ** Dependency symbol: +BR2_USE_MMU+ >> > ** Comment string: no comment to be added >> > >> >+* Kernel headers >> >+** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace >> >+ +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) >> >+** Comment string: `headers >= X.Y` (replace +X.Y+ with the >> >+ proper version) >> >> Are these backticks? >> Is there a specific reason you use this instead of single or double quotes? > >I just duplicated what wah done for C++, a few lines below. > >Lookign at the other comments, it looks like C++ is the only one using >backticks, the others use the +blabla+ format. > >Will fix bot before submitting again. Ah now I understand again: the pluses in c++ required me to use backticks. While giving the feedback to you I forgot this was asciidoc syntax, sorry. Then it doesn't really matter...
Thomas, All, On 2014-02-16 21:45 +0100, Thomas De Schampheleire spake thusly: > "Yann E. MORIN" <yann.morin.1998@free.fr> schreef: > >On 2014-02-16 21:03 +0100, Thomas De Schampheleire spake thusly: > >> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef: [--SNIP--] > >> >+* Kernel headers > >> >+** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace > >> >+ +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) > >> >+** Comment string: `headers >= X.Y` (replace +X.Y+ with the > >> >+ proper version) > >> > >> Are these backticks? > >> Is there a specific reason you use this instead of single or double quotes? > > > >I just duplicated what wah done for C++, a few lines below. > > > >Lookign at the other comments, it looks like C++ is the only one using > >backticks, the others use the +blabla+ format. > > > >Will fix bot before submitting again. > > Ah now I understand again: the pluses in c++ required me to use backticks. > While giving the feedback to you I forgot this was asciidoc syntax, sorry. > Then it doesn't really matter... Well, I can just use +foo+ for the headers version, it makes it more in-line with the other comments, C++ is an exception. Regards, Yann E. MORIN.
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt index 754a145..1917823 100644 --- a/docs/manual/adding-packages-directory.txt +++ b/docs/manual/adding-packages-directory.txt @@ -218,6 +218,12 @@ use in the comment. ** Dependency symbol: +BR2_USE_MMU+ ** Comment string: no comment to be added +* Kernel headers +** Dependency synbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace + +X_Y+ with the proper version, see +toolchain/toolchain-common.in+) +** Comment string: `headers >= X.Y` (replace +X.Y+ with the + proper version) + * C library ** Dependency symbol: +BR2_TOOLCHAIN_USES_GLIBC+, +BR2_TOOLCHAIN_USES_UCLIBC+