| Message ID | 1392367637-21873-1-git-send-email-sr@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Stefan, On 14/02/2014 09:47, Stefan Roese wrote: > Patch f33b9bd3 > [arm: omap3: Enable clocks for peripherals only if they are used] > breaks SPL booting on tao3530. Since some gpio input's are > read to detect the board revision. But with this patch above, the > clocks to the GPIO subsystems are not enabled per default any more. > The GPIO banks need to be configured specifically now. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Tom Rini <trini@ti.com> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > --- > include/configs/tao3530.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/configs/tao3530.h b/include/configs/tao3530.h > index 9abfe82..9c04c23 100644 > --- a/include/configs/tao3530.h > +++ b/include/configs/tao3530.h > @@ -83,6 +83,13 @@ > #define CONFIG_OMAP_HSMMC > #define CONFIG_DOS_PARTITION > > +/* GPIO banks */ > +#define CONFIG_OMAP3_GPIO_2 /* GPIO32 ..63 is in GPIO bank 2 */ > +#define CONFIG_OMAP3_GPIO_3 /* GPIO64 ..95 is in GPIO bank 3 */ > +#define CONFIG_OMAP3_GPIO_4 /* GPIO96 ..127 is in GPIO bank 4 */ > +#define CONFIG_OMAP3_GPIO_5 /* GPIO128..159 is in GPIO bank 5 */ > +#define CONFIG_OMAP3_GPIO_6 /* GPIO160..191 is in GPIO bank 6 */ > + > /* commands to include */ > #include <config_cmd_default.h> > > I confirm the issue, I will send a similar patch for the mcx board. Reviewed-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic
On Fri, Feb 14, 2014 at 09:47:17AM +0100, Stefan Roese wrote: > Patch f33b9bd3 > [arm: omap3: Enable clocks for peripherals only if they are used] > breaks SPL booting on tao3530. Since some gpio input's are > read to detect the board revision. But with this patch above, the > clocks to the GPIO subsystems are not enabled per default any more. > The GPIO banks need to be configured specifically now. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Tom Rini <trini@ti.com> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > Reviewed-by: Stefano Babic <sbabic@denx.de> Applied to u-boot-ti/master, thanks!
diff --git a/include/configs/tao3530.h b/include/configs/tao3530.h index 9abfe82..9c04c23 100644 --- a/include/configs/tao3530.h +++ b/include/configs/tao3530.h @@ -83,6 +83,13 @@ #define CONFIG_OMAP_HSMMC #define CONFIG_DOS_PARTITION +/* GPIO banks */ +#define CONFIG_OMAP3_GPIO_2 /* GPIO32 ..63 is in GPIO bank 2 */ +#define CONFIG_OMAP3_GPIO_3 /* GPIO64 ..95 is in GPIO bank 3 */ +#define CONFIG_OMAP3_GPIO_4 /* GPIO96 ..127 is in GPIO bank 4 */ +#define CONFIG_OMAP3_GPIO_5 /* GPIO128..159 is in GPIO bank 5 */ +#define CONFIG_OMAP3_GPIO_6 /* GPIO160..191 is in GPIO bank 6 */ + /* commands to include */ #include <config_cmd_default.h>
Patch f33b9bd3 [arm: omap3: Enable clocks for peripherals only if they are used] breaks SPL booting on tao3530. Since some gpio input's are read to detect the board revision. But with this patch above, the clocks to the GPIO subsystems are not enabled per default any more. The GPIO banks need to be configured specifically now. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Tom Rini <trini@ti.com> Cc: Michael Trimarchi <michael@amarulasolutions.com> --- include/configs/tao3530.h | 7 +++++++ 1 file changed, 7 insertions(+)