diff mbox

[1/3] infozip: fix $(AS) behavior

Message ID 1391120098-8325-1-git-send-email-romain.naour@openwide.fr
State Accepted
Commit 08cd1208e5e8cef7d65cbb26f6145a3fa149636f
Headers show

Commit Message

Romain Naour Jan. 30, 2014, 10:14 p.m. UTC
infozip's Makefile expect $(AS) to output by default to <basename>.o
but when called from Buildroot, the value for $(AS) is set
to to invoke the toolchain's $(AS) directly, and the output of it
goes to a.out.

So, define $(AS) with $(CC -c)

Reported-by: Кирилл Луценко <lucenko_kirill@mail.ru>
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/infozip/infozip.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Feb. 2, 2014, 9:28 a.m. UTC | #1
>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:

 > infozip's Makefile expect $(AS) to output by default to <basename>.o
 > but when called from Buildroot, the value for $(AS) is set
 > to to invoke the toolchain's $(AS) directly, and the output of it
 > goes to a.out.

 > So, define $(AS) with $(CC -c)

 > Reported-by: Кирилл Луценко <lucenko_kirill@mail.ru>
 > Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Committed, thanks.
diff mbox

Patch

diff --git a/package/infozip/infozip.mk b/package/infozip/infozip.mk
index d73edd4..cc2bd34 100644
--- a/package/infozip/infozip.mk
+++ b/package/infozip/infozip.mk
@@ -11,7 +11,7 @@  INFOZIP_LICENSE = Info-ZIP
 INFOZIP_LICENSE_FILES = LICENSE
 
 define INFOZIP_BUILD_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile generic
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) AS="$(TARGET_CC) -c" -f unix/Makefile generic
 endef
 
 define INFOZIP_INSTALL_TARGET_CMDS