| Message ID | 1390501358-4564-3-git-send-email-dennis@ausil.us |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On 01/23/2014 11:22 AM, Dennis Gilmore wrote: > describe a set of default features that distros can rely on being available. > having this common definition means that distros can easily support systems > implementing them. The series, Tested-by: Stephen Warren <swarren@nvidia.com> Reviewed-by: Stephen Warren <swarren@nvidia.com> with one tiny nit: > diff --git a/include/config_distro_defaults.h b/include/config_distro_defaults.h > +#ifndef _CONFIG_CMD_DISTRO_DEFAULT_H > +#define _CONFIG_CMD_DISTRO_DEFAULT_H This file got renamed from config_distro_default.h in the RFC to config_distro_defaults.h in this patch, but the include guard wasn't updated.
Dear Dennis Gilmore, In message <1390501358-4564-3-git-send-email-dennis@ausil.us> you wrote: > describe a set of default features that distros can rely on being available. > having this common definition means that distros can easily support systems > implementing them. > > Signed-off-by: Dennis Gilmore <dennis@ausil.us> > --- > include/config_distro_defaults.h | 55 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 include/config_distro_defaults.h For this patch set this adds dead code. Please resubmit as part of a series that actually uses this. Best regards, Wolfgang Denk
Hi Wolfgang, El Fri, 24 Jan 2014 14:50:10 +0100 Wolfgang Denk <wd@denx.de> escribió: > Dear Dennis Gilmore, > > In message <1390501358-4564-3-git-send-email-dennis@ausil.us> you > wrote: > > describe a set of default features that distros can rely on being > > available. having this common definition means that distros can > > easily support systems implementing them. > > > > Signed-off-by: Dennis Gilmore <dennis@ausil.us> > > --- > > include/config_distro_defaults.h | 55 > > ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 > > insertions(+) create mode 100644 include/config_distro_defaults.h > > For this patch set this adds dead code. Please resubmit as part of a > series that actually uses this. in the cover email i put """ I have left out any implementations in this set of patches. I am working to redo all the implementations based on the work done by Stephen Warren in his recent set to base on top of these and his exists work. """ Stephen has submitted patches that use this code. and I will be submitting further patches that use it in the next few days. I will be submitting a V2 that fixes Stephens comment Dennis > > Best regards, > > Wolfgang Denk > -
On 01/24/2014 07:58 AM, Dennis Gilmore wrote: > Hi Wolfgang, > > > El Fri, 24 Jan 2014 14:50:10 +0100 > Wolfgang Denk <wd@denx.de> escribió: >> Dear Dennis Gilmore, >> >> In message <1390501358-4564-3-git-send-email-dennis@ausil.us> you >> wrote: >>> describe a set of default features that distros can rely on being >>> available. having this common definition means that distros can >>> easily support systems implementing them. >>> >>> Signed-off-by: Dennis Gilmore <dennis@ausil.us> >>> --- >>> include/config_distro_defaults.h | 55 >>> ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 >>> insertions(+) create mode 100644 include/config_distro_defaults.h >> >> For this patch set this adds dead code. Please resubmit as part of a >> series that actually uses this. > > in the cover email i put > """ > I have left out any implementations in this set of patches. I am > working to redo all the implementations based on the work done by > Stephen Warren in his recent set to base on top of these and his exists > work. > """ > > Stephen has submitted patches that use this code. and I will be > submitting further patches that use it in the next few days. Wolfgang, is this OK (Dennis submitting patches that adds a feature, and my submitting a separate series that uses it, all sent to the mailing list at the same time and applied together)? Or, do I need to physically send Dennis's patches in the same series as my patches? > I will be submitting a V2 that fixes Stephens comment Dennis, I don't think I saw V2 of this series?
diff --git a/include/config_distro_defaults.h b/include/config_distro_defaults.h new file mode 100644 index 0000000..7b13586 --- /dev/null +++ b/include/config_distro_defaults.h @@ -0,0 +1,55 @@ +/* + * Copyright 2013 Red Hat, Inc. + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#ifndef _CONFIG_CMD_DISTRO_DEFAULT_H +#define _CONFIG_CMD_DISTRO_DEFAULT_H + +/* + * List of all commands and options that when defined enables support for features + * required by distros to support boards in a standardised and consitant manner. + */ + +#define CONFIG_BOOTP_BOOTPATH +#define CONFIG_BOOTP_DNS +#define CONFIG_BOOTP_GATEWAY +#define CONFIG_BOOTP_HOSTNAME +#define CONFIG_BOOTP_PXE +#define CONFIG_BOOTP_SUBNETMASK + +#if defined(__arm__) +#define CONFIG_BOOTP_PXE_CLIENTARCH 0x100 +#if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__) +#define CONFIG_BOOTP_VCI_STRING "U-boot.armv7" +#else +#define CONFIG_BOOTP_VCI_STRING "U-boot.arm" +#endif +#endif + +#define CONFIG_OF_LIBFDT + +#define CONFIG_CMD_BOOTZ +#define CONFIG_CMD_DHCP +#define CONFIG_CMD_ELF +#define CONFIG_CMD_EXT2 +#define CONFIG_CMD_EXT4 +#define CONFIG_CMD_FAT +#define CONFIG_CMD_FS_GENERIC +#define CONFIG_CMD_MII +#define CONFIG_CMD_NET +#define CONFIG_CMD_PING +#define CONFIG_CMD_PXE + +#define CONFIG_CMDLINE_EDITING +#define CONFIG_AUTO_COMPLETE +#define CONFIG_BOOTDELAY 2 +#define CONFIG_SYS_LONGHELP +#define CONFIG_MENU +#define CONFIG_DOS_PARTITION +#define CONFIG_EFI_PARTITION +#define CONFIG_SUPPORT_RAW_INITRD +#define CONFIG_SYS_HUSH_PARSER + +#endif /* _CONFIG_CMD_DISTRO_DEFAULT_H */
describe a set of default features that distros can rely on being available. having this common definition means that distros can easily support systems implementing them. Signed-off-by: Dennis Gilmore <dennis@ausil.us> --- include/config_distro_defaults.h | 55 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 include/config_distro_defaults.h