diff mbox

[v3,06/12] libshairplay: new package

Message ID 1390165448-9130-7-git-send-email-maxime.hadjinlian@gmail.com
State Accepted
Headers show

Commit Message

Maxime Hadjinlian Jan. 19, 2014, 9:04 p.m. UTC
libshairplay is a client library that emulates an airplay server
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <ebsi4711@gmail.com>

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Cc: gimli <ebsi4711@gmail.com>
---
Changes v2 -> v3:
  - Fix dependencies (Yann E. Morin)
  - Fix licenses (Yann E. Morin)
Changes v1 -> v2:
  - Fix header (Yann E. Morin)
  - Fix comment on toolchain option (Peter Korsgaard)
---
 package/Config.in                    |  1 +
 package/libshairplay/Config.in       | 11 +++++++++++
 package/libshairplay/libshairplay.mk | 15 +++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/libshairplay/Config.in
 create mode 100644 package/libshairplay/libshairplay.mk

Comments

Peter Korsgaard Jan. 22, 2014, 10:48 p.m. UTC | #1
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 > libshairplay is a client library that emulates an airplay server
 > This package was originally found at : https://github.com/huceke/buildroot-rbp
 > By gimli <ebsi4711@gmail.com>

Committed with minor fixes (see below) - Thanks.

 > +config BR2_PACKAGE_LIBSHAIRPLAY
 > +  bool "libshairplay"
 > +  depends on BR2_INET_IPV6
 > +  help

Indentation is wrong (should be tab).

It uses pthreads, so it should also depend on BR2_TOOLCHAIN_HAS_THREADS.

 > +++ b/package/libshairplay/libshairplay.mk
 > @@ -0,0 +1,15 @@
 > +################################################################################
 > +#
 > +# libshairplay
 > +#
 > +################################################################################
 > +
 > +LIBSHAIRPLAY_VERSION = 139d5ef55564514c31f02dd82cef91236c9ff523
 > +LIBSHAIRPLAY_SITE = $(call github,juhovh,shairplay,$(LIBSHAIRPLAY_VERSION))
 > +LIBSHAIRPLAY_INSTALL_STAGING = YES
 > +LIBSHAIRPLAY_INSTALL_TARGET = YES

This defaults to YES, so that isn't needed.

 > +LIBSHAIRPLAY_AUTORECONF = YES
 > +LIBSHAIRPLAY_LICENSE = MIT, BSD-3c, LGPLv2.1+
 > +LIBSHAIRPLAY_LICENSE_FILES = LICENSE

The configure script uses pkg-config so it should depend on
host-pkgconf. It also has optional support for libao, so we should add
that as well if enabled.
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 3a867b0..d400ea2 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -680,6 +680,7 @@  source "package/liboping/Config.in"
 source "package/libosip2/Config.in"
 source "package/libpcap/Config.in"
 source "package/librsync/Config.in"
+source "package/libshairplay/Config.in"
 source "package/libsoup/Config.in"
 source "package/libtirpc/Config.in"
 source "package/libtorrent/Config.in"
diff --git a/package/libshairplay/Config.in b/package/libshairplay/Config.in
new file mode 100644
index 0000000..9fad7b4
--- /dev/null
+++ b/package/libshairplay/Config.in
@@ -0,0 +1,11 @@ 
+config BR2_PACKAGE_LIBSHAIRPLAY
+  bool "libshairplay"
+  depends on BR2_INET_IPV6
+  help
+    libshairplay is a client library that emulates an airplay
+    server
+
+    https://github.com/juhovh/shairplay
+
+comment "libshairplay needs a toolchain w/ IPv6"
+	depends on !BR2_INET_IPV6
diff --git a/package/libshairplay/libshairplay.mk b/package/libshairplay/libshairplay.mk
new file mode 100644
index 0000000..c40a1b5
--- /dev/null
+++ b/package/libshairplay/libshairplay.mk
@@ -0,0 +1,15 @@ 
+################################################################################
+#
+# libshairplay
+#
+################################################################################
+
+LIBSHAIRPLAY_VERSION = 139d5ef55564514c31f02dd82cef91236c9ff523
+LIBSHAIRPLAY_SITE = $(call github,juhovh,shairplay,$(LIBSHAIRPLAY_VERSION))
+LIBSHAIRPLAY_INSTALL_STAGING = YES
+LIBSHAIRPLAY_INSTALL_TARGET = YES
+LIBSHAIRPLAY_AUTORECONF = YES
+LIBSHAIRPLAY_LICENSE = MIT, BSD-3c, LGPLv2.1+
+LIBSHAIRPLAY_LICENSE_FILES = LICENSE
+
+$(eval $(autotools-package))