| Message ID | CAAVaN8w+0gETH6oL-c+v1J86BzmFCyZ9t3crOYU7KCbsCFr5aA@mail.gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
On Sun, Jan 19, 2014 at 12:34 PM, Andy Ng <andreas2025@gmail.com> wrote:
> The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10
Please:
- Add Signed-off-by
- Rebase it to imx/master as this does not apply in current source code.
Hi Andy, On 19/01/2014 15:34, Andy Ng wrote: > The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 > > We agree about your patch, but can you please fix the issues reported by Otavio (add your signed-off-by and rebase) and resubmit, please ? Thanks, Stefano Babic
Hello, On Tue, Feb 11, 2014 at 8:13 AM, Stefano Babic <sbabic@denx.de> wrote: > On 19/01/2014 15:34, Andy Ng wrote: >> The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 > > We agree about your patch, but can you please fix the issues reported by > Otavio (add your signed-off-by and rebase) and resubmit, please ? I have reworked Andy's patch and applied to my internal tree. I can send it if needed.
Hi Otavio, On 11/02/2014 11:55, Otavio Salvador wrote: > Hello, > > On Tue, Feb 11, 2014 at 8:13 AM, Stefano Babic <sbabic@denx.de> wrote: >> On 19/01/2014 15:34, Andy Ng wrote: >>> The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 >> >> We agree about your patch, but can you please fix the issues reported by >> Otavio (add your signed-off-by and rebase) and resubmit, please ? > > I have reworked Andy's patch and applied to my internal tree. I can > send it if needed. Thanks, wait on. I would like to know from Andy if it is ok for him to add his Signed-off-by, before applying. If Andy is not available, we will rework the patch. Regards, Stefano
Hello, On Tue, Feb 11, 2014 at 9:11 AM, Stefano Babic <sbabic@denx.de> wrote: > Hi Otavio, > > On 11/02/2014 11:55, Otavio Salvador wrote: >> Hello, >> >> On Tue, Feb 11, 2014 at 8:13 AM, Stefano Babic <sbabic@denx.de> wrote: >>> On 19/01/2014 15:34, Andy Ng wrote: >>>> The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 >>> >>> We agree about your patch, but can you please fix the issues reported by >>> Otavio (add your signed-off-by and rebase) and resubmit, please ? >> >> I have reworked Andy's patch and applied to my internal tree. I can >> send it if needed. > > Thanks, wait on. I would like to know from Andy if it is ok for him to > add his Signed-off-by, before applying. If Andy is not available, we > will rework the patch. In fact Andy's patch was not complete. So I did it: -- MX6: Add SION flag to ENET_REF_CLK PAD The ENET_REF_CLK needs to have the SION flag enabled so it can loopback. This patch has been based upon an Andy Ng <andreas2025@gmail.com> one. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> -- So when you want, I can send it.
Hi Otavio, On 11/02/2014 14:03, Otavio Salvador wrote: > Hello, > > On Tue, Feb 11, 2014 at 9:11 AM, Stefano Babic <sbabic@denx.de> wrote: >> Hi Otavio, >> >> On 11/02/2014 11:55, Otavio Salvador wrote: >>> Hello, >>> >>> On Tue, Feb 11, 2014 at 8:13 AM, Stefano Babic <sbabic@denx.de> wrote: >>>> On 19/01/2014 15:34, Andy Ng wrote: >>>>> The ENET_REF_CLK has to loopback: the patch was produced from u-boot 2013-10 >>>> >>>> We agree about your patch, but can you please fix the issues reported by >>>> Otavio (add your signed-off-by and rebase) and resubmit, please ? >>> >>> I have reworked Andy's patch and applied to my internal tree. I can >>> send it if needed. >> >> Thanks, wait on. I would like to know from Andy if it is ok for him to >> add his Signed-off-by, before applying. If Andy is not available, we >> will rework the patch. > > In fact Andy's patch was not complete. So I did it: > > -- > MX6: Add SION flag to ENET_REF_CLK PAD > The ENET_REF_CLK needs to have the SION flag enabled so it can > > loopback. > > This patch has been based upon an Andy Ng <andreas2025@gmail.com> one. > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > -- > Thanks - if we do not know anything from Andy in a couple of days, please send it. Regards, Stefano
Hi Andy, On 12/02/2014 12:53, Andy Ng wrote: > HI > > I was away the last few days. > > Shall I produce a patch for the u-boot git main line code with that fix? Yes, please add your signed-off-by and rebase it on top of u-boot-imx. Thanks, Stefano Babic
diff --git a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h index 7851eb1..9c18847 100644 --- a/arch/arm/include/asm/arch-mx6/mx6dl_pins.h +++ b/arch/arm/include/asm/arch-mx6/mx6dl_pins.h @@ -1047,7 +1047,7 @@ MX6_PAD_DECL(GPIO_1__USDHC1_CD , 0x05E0, 0x0210, 6, 0x0000, 0, 0) MX6_PAD_DECL(GPIO_1__SRC_TESTER_ACK , 0x05E0, 0x0210, 7, 0x0000, 0, 0) MX6_PAD_DECL(GPIO_16__ESAI1_TX3_RX2 , 0x05E4, 0x0214, 0, 0x0850, 1, 0) MX6_PAD_DECL(GPIO_16__ENET_1588_EVENT2_IN , 0x05E4, 0x0214, 1, 0x0000, 0, 0)