| Message ID | 1389682946-29694-4-git-send-email-l.majewski@samsung.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On 14/01/14 16:02, Lukasz Majewski wrote: > Disable L2 caches for Trats and Trats2 devices. > > It turns out that for data downloading with thordown command L2 cache > disablement brings a significant speed improvement. > > rootfs - 400 MiB: > - L2 cache enabled: 2.69 MiB/s > - L2 cache disabled: 5.56 MiB/s > > Such improvement is possible due to reduction of the need to invalidate > redundant data, which resides in L2 cache. > > Since the sent USB request size at once is 512B (L1 - 32 KiB in total) - > one can be quite confident that it is already available in L1 and L2 can > be disabled. > > Change-Id: I911ea18075526f7e8295c30dfcf7a658ebc4e53b > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > --- > include/configs/trats.h | 1 + > include/configs/trats2.h | 1 + > 2 files changed, 2 insertions(+) > Acked-by: Minkyu Kang <mk7.kang@samsung.com> Thanks, Minkyu Kang.
On Tue, Jan 14, 2014 at 08:02:26AM +0100, Łukasz Majewski wrote: > Disable L2 caches for Trats and Trats2 devices. > > It turns out that for data downloading with thordown command L2 cache > disablement brings a significant speed improvement. > > rootfs - 400 MiB: > - L2 cache enabled: 2.69 MiB/s > - L2 cache disabled: 5.56 MiB/s > > Such improvement is possible due to reduction of the need to invalidate > redundant data, which resides in L2 cache. > > Since the sent USB request size at once is 512B (L1 - 32 KiB in total) - > one can be quite confident that it is already available in L1 and L2 can > be disabled. > > Change-Id: I911ea18075526f7e8295c30dfcf7a658ebc4e53b > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Acked-by: Minkyu Kang <mk7.kang@samsung.com> Applied to u-boot/master, thanks!
diff --git a/include/configs/trats.h b/include/configs/trats.h index 0bdfe86..fdd8b46 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -27,6 +27,7 @@ #define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_SYS_L2CACHE_OFF #ifndef CONFIG_SYS_L2CACHE_OFF #define CONFIG_SYS_L2_PL310 #define CONFIG_SYS_PL310_BASE 0x10502000 diff --git a/include/configs/trats2.h b/include/configs/trats2.h index 8e4b215..83633b0 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -30,6 +30,7 @@ #define CONFIG_SYS_CACHELINE_SIZE 32 +#define CONFIG_SYS_L2CACHE_OFF #ifndef CONFIG_SYS_L2CACHE_OFF #define CONFIG_SYS_L2_PL310 #define CONFIG_SYS_PL310_BASE 0x10502000
Disable L2 caches for Trats and Trats2 devices. It turns out that for data downloading with thordown command L2 cache disablement brings a significant speed improvement. rootfs - 400 MiB: - L2 cache enabled: 2.69 MiB/s - L2 cache disabled: 5.56 MiB/s Such improvement is possible due to reduction of the need to invalidate redundant data, which resides in L2 cache. Since the sent USB request size at once is 512B (L1 - 32 KiB in total) - one can be quite confident that it is already available in L1 and L2 can be disabled. Change-Id: I911ea18075526f7e8295c30dfcf7a658ebc4e53b Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> --- include/configs/trats.h | 1 + include/configs/trats2.h | 1 + 2 files changed, 2 insertions(+)