diff mbox

[1/3] linux-user: fixed s390x clone() argument order

Message ID 1389432851-11420-2-git-send-email-pavel.zbitskiy@gmail.com
State New
Headers show

Commit Message

Pavel Zbitskiy Jan. 11, 2014, 9:34 a.m. UTC
From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>

It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db,
where TARGET_CLONE_BACKWARDS was specified instead of
TARGET_CLONE_BACKWARDS2.

Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
---
 linux-user/s390x/syscall.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Maydell Jan. 12, 2014, 6:56 p.m. UTC | #1
On 11 January 2014 09:34,  <pavel.zbitskiy@gmail.com> wrote:
> From: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
>
> It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db,
> where TARGET_CLONE_BACKWARDS was specified instead of
> TARGET_CLONE_BACKWARDS2.
>
> Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com>
> ---
>  linux-user/s390x/syscall.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/s390x/syscall.h b/linux-user/s390x/syscall.h
> index ea8c304..e5ce30b 100644
> --- a/linux-user/s390x/syscall.h
> +++ b/linux-user/s390x/syscall.h
> @@ -22,4 +22,4 @@ struct target_pt_regs {
>
>  #define UNAME_MACHINE "s390x"
>
> -#define TARGET_CLONE_BACKWARDS
> +#define TARGET_CLONE_BACKWARDS2

Yep, kernel config agrees:
http://lxr.free-electrons.com/source/arch/s390/Kconfig#L99

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM
diff mbox

Patch

diff --git a/linux-user/s390x/syscall.h b/linux-user/s390x/syscall.h
index ea8c304..e5ce30b 100644
--- a/linux-user/s390x/syscall.h
+++ b/linux-user/s390x/syscall.h
@@ -22,4 +22,4 @@  struct target_pt_regs {
 
 #define UNAME_MACHINE "s390x"
 
-#define TARGET_CLONE_BACKWARDS
+#define TARGET_CLONE_BACKWARDS2