diff mbox

[U-Boot] ARM: twister: add missing gpio clock init

Message ID 1387645593-26416-1-git-send-email-jeroen@myspectrum.nl
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Jeroen Hofstee Dec. 21, 2013, 5:06 p.m. UTC
Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards
which do not explicitly enable the gpio clocks. This causes
the twister spl to hang, since it uses the no longer enabled
gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.

Cc: Stefano Babic <sbabic@denx.de>
Cc: Tapani Utriainen <tapani@technexion.com>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
 include/configs/twister.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Stefano Babic Dec. 27, 2013, 10:53 a.m. UTC | #1
On 21/12/2013 18:06, Jeroen Hofstee wrote:
> Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards
> which do not explicitly enable the gpio clocks. This causes
> the twister spl to hang, since it uses the no longer enabled
> gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.
> 
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tapani Utriainen <tapani@technexion.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> ---
>  include/configs/twister.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/configs/twister.h b/include/configs/twister.h
> index b6ca59c..f24dc13 100644
> --- a/include/configs/twister.h
> +++ b/include/configs/twister.h
> @@ -50,4 +50,7 @@
>  #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
>  #define CONFIG_SPL_BOARD_INIT
>  
> +/* gpio 55 is used as SPL_OS_BOOT_KEY */
> +#define CONFIG_OMAP3_GPIO_2
> +
>  #endif /* __CONFIG_H */
> 


Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Tom Rini Jan. 8, 2014, 1:34 p.m. UTC | #2
On Sat, Dec 21, 2013 at 06:06:33PM +0100, Jeroen Hofstee wrote:

> Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards
> which do not explicitly enable the gpio clocks. This causes
> the twister spl to hang, since it uses the no longer enabled
> gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.
> 
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tapani Utriainen <tapani@technexion.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Acked-by: Stefano Babic <sbabic@denx.de>

Applied to u-boot-ti/master, thanks!
diff mbox

Patch

diff --git a/include/configs/twister.h b/include/configs/twister.h
index b6ca59c..f24dc13 100644
--- a/include/configs/twister.h
+++ b/include/configs/twister.h
@@ -50,4 +50,7 @@ 
 #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
 #define CONFIG_SPL_BOARD_INIT
 
+/* gpio 55 is used as SPL_OS_BOOT_KEY */
+#define CONFIG_OMAP3_GPIO_2
+
 #endif /* __CONFIG_H */