| Message ID | 1387178843-22245-1-git-send-email-voice.shen@atmel.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On 16 December 2013 00:27, Bo Shen <voice.shen@atmel.com> wrote: > Fix the typo error for mrproper from mkproper. > > Signed-off-by: Bo Shen <voice.shen@atmel.com> Adding Masahiro. > --- > In Makefile, there is no object name is mkproper, so I think this is > a typo error. > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 7310c4e..ddbaaf0 100644 > --- a/Makefile > +++ b/Makefile > @@ -168,7 +168,7 @@ endif > include $(TOPDIR)/config.mk > > # Targets which don't build the source code > -NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig > +NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig > > # Only do the generic board check when actually building, not configuring > ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),) > -- > 1.7.9.5 >
On Mon, Dec 16, 2013 at 08:53:08AM -0700, Simon Glass wrote: > On 16 December 2013 00:27, Bo Shen <voice.shen@atmel.com> wrote: > > Fix the typo error for mrproper from mkproper. > > > > Signed-off-by: Bo Shen <voice.shen@atmel.com> > > Adding Masahiro. > > > --- > > In Makefile, there is no object name is mkproper, so I think this is > > a typo error. > > > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 7310c4e..ddbaaf0 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -168,7 +168,7 @@ endif > > include $(TOPDIR)/config.mk > > > > # Targets which don't build the source code > > -NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig > > +NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig > > > > # Only do the generic board check when actually building, not configuring > > ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),) Note all of this logic came in with fada9e2 which is you, Simon :) But I'm pretty sure this is trivially correct, so I'll take it soon.
Hi Tom, On 16 December 2013 09:38, Tom Rini <trini@ti.com> wrote: > On Mon, Dec 16, 2013 at 08:53:08AM -0700, Simon Glass wrote: >> On 16 December 2013 00:27, Bo Shen <voice.shen@atmel.com> wrote: >> > Fix the typo error for mrproper from mkproper. >> > >> > Signed-off-by: Bo Shen <voice.shen@atmel.com> >> >> Adding Masahiro. >> >> > --- >> > In Makefile, there is no object name is mkproper, so I think this is >> > a typo error. >> > >> > Makefile | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/Makefile b/Makefile >> > index 7310c4e..ddbaaf0 100644 >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -168,7 +168,7 @@ endif >> > include $(TOPDIR)/config.mk >> > >> > # Targets which don't build the source code >> > -NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig >> > +NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig >> > >> > # Only do the generic board check when actually building, not configuring >> > ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),) > > Note all of this logic came in with fada9e2 which is you, Simon :) But > I'm pretty sure this is trivially correct, so I'll take it soon. OK, I see. Yes looks right. Acked-by: Simon Glass <sjg@chromium.org> Regards, Simon
On Mon, Dec 16, 2013 at 03:27:23PM +0800, Bo Shen wrote: > Fix the typo error for mrproper from mkproper. > > Signed-off-by: Bo Shen <voice.shen@atmel.com> > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/Makefile b/Makefile index 7310c4e..ddbaaf0 100644 --- a/Makefile +++ b/Makefile @@ -168,7 +168,7 @@ endif include $(TOPDIR)/config.mk # Targets which don't build the source code -NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig +NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig # Only do the generic board check when actually building, not configuring ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)
Fix the typo error for mrproper from mkproper. Signed-off-by: Bo Shen <voice.shen@atmel.com> --- In Makefile, there is no object name is mkproper, so I think this is a typo error. Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)