Patchwork [U-Boot,1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails

login
register
mail settings
Submitter Fabio Estevam
Date Nov. 4, 2013, 12:03 a.m.
Message ID <1383523384-6090-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/288086/
State Accepted
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Nov. 4, 2013, 12:03 a.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

If ipuv3_fb_init() fails, we should return the error immediately.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/wandboard/wandboard.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Stefano Babic - Nov. 13, 2013, 9:14 a.m.
On 04/11/2013 01:03, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> If ipuv3_fb_init() fails, we should return the error immediately.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 23a78c1..99150f9 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -230,8 +230,10 @@  int board_video_skip(void)
 
 	ret = ipuv3_fb_init(&hdmi, 0, IPU_PIX_FMT_RGB24);
 
-	if (ret)
+	if (ret) {
 		printf("HDMI cannot be configured: %d\n", ret);
+		return ret;
+	}
 
 	imx_enable_hdmi_phy();