Patchwork [U-Boot,3/5] udoo: Change FDT loading address to avoid overlaping

login
register
mail settings
Submitter Otavio Salvador
Date Nov. 1, 2013, 11:25 a.m.
Message ID <1383305158-26019-3-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/287796/
State Changes Requested
Delegated to: Stefano Babic
Headers show

Comments

Otavio Salvador - Nov. 1, 2013, 11:25 a.m.
The new FSL 3.10.9_1.0.0-alpha kernel requires more memory space and
with the previous loading address we had ovelap; change it for the
same address used in 2013.04-3.10.9_1.0.0-alpha U-Boot.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 include/configs/udoo.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Wolfgang Denk - Nov. 1, 2013, 12:40 p.m.
Dear Otavio Salvador,

In message <1383305158-26019-3-git-send-email-otavio@ossystems.com.br> you wrote:
> The new FSL 3.10.9_1.0.0-alpha kernel requires more memory space and
> with the previous loading address we had ovelap; change it for the
> same address used in 2013.04-3.10.9_1.0.0-alpha U-Boot.

What exactly is "2013.04-3.10.9_1.0.0-alpha" ?  It makes no sense to
add any such references which are meaningless to the reader.

Best regards,

Wolfgang Denk
Otavio Salvador - Nov. 1, 2013, 1:05 p.m.
On Fri, Nov 1, 2013 at 10:40 AM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Otavio Salvador,
>
> In message <1383305158-26019-3-git-send-email-otavio@ossystems.com.br> you wrote:
>> The new FSL 3.10.9_1.0.0-alpha kernel requires more memory space and
>> with the previous loading address we had ovelap; change it for the
>> same address used in 2013.04-3.10.9_1.0.0-alpha U-Boot.
>
> What exactly is "2013.04-3.10.9_1.0.0-alpha" ?  It makes no sense to
> add any such references which are meaningless to the reader.

Please look at the other patch where Fabio and I are discussing about
this commit log. In fact it is not meaningless but current FSL fork of
U-Boot 2013.04 for 3.10.9-1.0.0 BSP.
Wolfgang Denk - Nov. 1, 2013, 8:24 p.m.
Dear Otavio Salvador,

In message <CAP9ODKpGwQMN0udK_V_o=Q759sDbn7YG1xnr2BpQyiKXXZYdWQ@mail.gmail.com> you wrote:
>
> Please look at the other patch where Fabio and I are discussing about
> this commit log. In fact it is not meaningless but current FSL fork of
> U-Boot 2013.04 for 3.10.9-1.0.0 BSP.

It is meaningless to the reader of this commit message.  A commit
message may be read in a couple of years, and even people who don;t
remember what you are discussing now on the mailing list should be
able to understand it.

So please provide a desription that provides sufficient context so it
can be understood.

Thanks.

Wolfgang Denk

Patch

diff --git a/include/configs/udoo.h b/include/configs/udoo.h
index 78df071..a5991aa 100644
--- a/include/configs/udoo.h
+++ b/include/configs/udoo.h
@@ -77,7 +77,7 @@ 
 	"fdt_high=0xffffffff\0" \
 	"initrd_high=0xffffffff\0" \
 	"fdt_file=" CONFIG_DEFAULT_FDT_FILE "\0" \
-	"fdt_addr=0x11000000\0" \
+	"fdt_addr=0x18000000\0" \
 	"boot_fdt=try\0" \
 	"ip_dyn=yes\0" \
 	"mmcdev=0\0" \