| Message ID | 1381934232-55158-19-git-send-email-sson@FreeBSD.org |
|---|---|
| State | New |
| Headers | show |
sson@FreeBSD.org writes: > This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, > mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. > > Signed-off-by: Stacey Son <sson@FreeBSD.org> > --- <snip> > new file mode 100644 > index 0000000..46d4aa2 > --- /dev/null > +++ b/default-configs/arm-bsd-user.mak > @@ -0,0 +1,3 @@ > +# Default configuration for arm-linux-user Comment wrong > + > +CONFIG_GDBSTUB_XML=y <snip> Given how little is typically in the -user .mak fragments I wonder what the point of them is. Should the build fall-back to a generic .mak fragment if there is no special config for a given build target?
On Oct 16, 2013, at 10:22 AM, Alex Bennée <alex.bennee@linaro.org> wrote: > > sson@FreeBSD.org writes: > >> This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, >> mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. >> >> Signed-off-by: Stacey Son <sson@FreeBSD.org> >> --- > <snip> >> new file mode 100644 >> index 0000000..46d4aa2 >> --- /dev/null >> +++ b/default-configs/arm-bsd-user.mak >> @@ -0,0 +1,3 @@ >> +# Default configuration for arm-linux-user > Comment wrong Yes, indeed. Now we know the source of this file. I fixed that in the patch set at http://people.freebsd.org/~sson/qemu/qemu-1.6.1/ <snip> -stacey.
On 16 October 2013 15:37, Stacey Son <sson@freebsd.org> wrote: > This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, > mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. > diff --git a/default-configs/arm-bsd-user.mak b/default-configs/arm-bsd-user.mak > new file mode 100644 > index 0000000..46d4aa2 > --- /dev/null > +++ b/default-configs/arm-bsd-user.mak > @@ -0,0 +1,3 @@ > +# Default configuration for arm-linux-user Comment doesn't match filename... -- PMM
On 16 October 2013 16:22, Alex Bennée <alex.bennee@linaro.org> wrote: > Given how little is typically in the -user .mak fragments I wonder what > the point of them is. Should the build fall-back to a generic .mak > fragment if there is no special config for a given build target? At the moment our list of "targets that you can build" is exactly "list of targets with a .mak file", so in order to have a generic .mak you'd need to have a list of supported targets somewhere else. Personally I'm not sure that's worth doing (possibly the "move to Kconfig" work will obsolete these files anyway.) -- PMM
diff --git a/default-configs/arm-bsd-user.mak b/default-configs/arm-bsd-user.mak new file mode 100644 index 0000000..46d4aa2 --- /dev/null +++ b/default-configs/arm-bsd-user.mak @@ -0,0 +1,3 @@ +# Default configuration for arm-linux-user + +CONFIG_GDBSTUB_XML=y diff --git a/default-configs/mips-bsd-user.mak b/default-configs/mips-bsd-user.mak new file mode 100644 index 0000000..3fb129a --- /dev/null +++ b/default-configs/mips-bsd-user.mak @@ -0,0 +1 @@ +# Default configuration for mips-bsd-user diff --git a/default-configs/mips64-bsd-user.mak b/default-configs/mips64-bsd-user.mak new file mode 100644 index 0000000..d4e72a6 --- /dev/null +++ b/default-configs/mips64-bsd-user.mak @@ -0,0 +1 @@ +# Default configuration for mips64-bsd-user diff --git a/default-configs/mips64el-bsd-user.mak b/default-configs/mips64el-bsd-user.mak new file mode 100644 index 0000000..b879228 --- /dev/null +++ b/default-configs/mips64el-bsd-user.mak @@ -0,0 +1 @@ +# Default configuration for mips64el-bsd-user diff --git a/default-configs/mipsel-bsd-user.mak b/default-configs/mipsel-bsd-user.mak new file mode 100644 index 0000000..312b9d5 --- /dev/null +++ b/default-configs/mipsel-bsd-user.mak @@ -0,0 +1 @@ +# Default configuration for mipsel-bsd-user
This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. Signed-off-by: Stacey Son <sson@FreeBSD.org> --- default-configs/arm-bsd-user.mak | 3 +++ default-configs/mips-bsd-user.mak | 1 + default-configs/mips64-bsd-user.mak | 1 + default-configs/mips64el-bsd-user.mak | 1 + default-configs/mipsel-bsd-user.mak | 1 + 5 files changed, 7 insertions(+), 0 deletions(-) create mode 100644 default-configs/arm-bsd-user.mak create mode 100644 default-configs/mips-bsd-user.mak create mode 100644 default-configs/mips64-bsd-user.mak create mode 100644 default-configs/mips64el-bsd-user.mak create mode 100644 default-configs/mipsel-bsd-user.mak