diff mbox

package/makedevs: add "l" type for symlink ownership

Message ID 5259B05A.20005@gmail.com
State Rejected
Headers show

Commit Message

angelo Oct. 12, 2013, 8:26 p.m. UTC 
Add to makedevs the 'l' type, to allow symlinks ownership change.
     Add related change on the makedevs doc.

     Singed-off-by: Angelo Dureghello <angelo@barix.com>

                 } else
                 {
                         dev_t rdev;
diff mbox

Patch

diff --git a/docs/manual/makedev-syntax.txt b/docs/manual/makedev-syntax.txt
index 2c98531..2392dc1 100644
--- a/docs/manual/makedev-syntax.txt
+++ b/docs/manual/makedev-syntax.txt
@@ -27,6 +27,7 @@  There are a few non-trivial blocks here:
    * c: a character device file
    * b: a block device file
    * p: a named pipe
+  * l: a symbolic link, for ownership changes only
  - +mode+, +uid+ and +gid+ are the usual permissions settings
  - +major+ and +minor+ are here for device files - set to - for other
    files
diff --git a/package/makedevs/makedevs.c b/package/makedevs/makedevs.c
index ab90b93..026533e 100644
--- a/package/makedevs/makedevs.c
+++ b/package/makedevs/makedevs.c
@@ -474,6 +474,18 @@  int main(int argc, char **argv)
                                 ret = EXIT_FAILURE;
                                 goto loop;
                         }
+               } else if (type == 'l') {
+                       struct stat st;
+                       if ((lstat(full_name, &st) < 0 || 
!S_ISLNK(st.st_mode))) {
+                               bb_perror_msg("line %d: invalid link for 
%s", linenum, full_name);
+                               ret = EXIT_FAILURE;
+                               goto loop;
+                       }
+                       if (lchown(full_name, uid, gid) == -1) {
+                               bb_perror_msg("line %d: chown failed for 
%s", linenum, full_name);
+                               ret = EXIT_FAILURE;
+                               goto loop;
+                       }