| Message ID | 20131009182955.GA15296@home.buserror.net |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: > Sorry for the lateness, but here are some MTD/UBI bugfixes. They've > been acked by Stefan Roese. > > The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: > > Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-nand-flash.git master > > for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: > > cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) > > ---------------------------------------------------------------- > Paul Burton (4): > mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > cmd_mtdparts: use 64 bits for flash size, partition size & offset > cmd_ubi: use int64_t volume size for 'ubi create' > cmd_ubi: add write.part command, to write a volume in multiple parts OK, problem: Author: Paul Burton <paul.burton@imgtec.com> Date: Wed Sep 4 15:16:57 2013 +0100 cmd_mtdparts: use 64 bits for flash size, partition size & offset Causes a number of platform such as am3517_crane to fail to build with recent toolchains with errors such as: /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: error: /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) uses VFP register arguments, u-boot does not Which we need to sort out, one way or another. Albert, any quick ideas?
Hi Tom, On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: > On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: > > > Sorry for the lateness, but here are some MTD/UBI bugfixes. They've > > been acked by Stefan Roese. > > > > The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: > > > > Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) > > > > are available in the git repository at: > > > > git://git.denx.de/u-boot-nand-flash.git master > > > > for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: > > > > cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) > > > > ---------------------------------------------------------------- > > Paul Burton (4): > > mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > > cmd_mtdparts: use 64 bits for flash size, partition size & offset > > cmd_ubi: use int64_t volume size for 'ubi create' > > cmd_ubi: add write.part command, to write a volume in multiple parts > > OK, problem: > Author: Paul Burton <paul.burton@imgtec.com> > Date: Wed Sep 4 15:16:57 2013 +0100 > > cmd_mtdparts: use 64 bits for flash size, partition size & offset > > Causes a number of platform such as am3517_crane to fail to build with > recent toolchains with errors such as: > /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: > error: > /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) > uses VFP register arguments, u-boot does not > > Which we need to sort out, one way or another. Albert, any quick ideas? Builds OK on my side, both nand-flash/master and a merge of nf/master and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) Tom, can you specify which toolchain shows the issue? Amicalement,
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/10/2013 04:12 AM, Albert ARIBAUD wrote: > Hi Tom, > > On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: > >> On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: >> >>> Sorry for the lateness, but here are some MTD/UBI bugfixes. They've >>> been acked by Stefan Roese. >>> >>> The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: >>> >>> Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) >>> >>> are available in the git repository at: >>> >>> git://git.denx.de/u-boot-nand-flash.git master >>> >>> for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: >>> >>> cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) >>> >>> ---------------------------------------------------------------- >>> Paul Burton (4): >>> mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN >>> cmd_mtdparts: use 64 bits for flash size, partition size & offset >>> cmd_ubi: use int64_t volume size for 'ubi create' >>> cmd_ubi: add write.part command, to write a volume in multiple parts >> >> OK, problem: >> Author: Paul Burton <paul.burton@imgtec.com> >> Date: Wed Sep 4 15:16:57 2013 +0100 >> >> cmd_mtdparts: use 64 bits for flash size, partition size & offset >> >> Causes a number of platform such as am3517_crane to fail to build with >> recent toolchains with errors such as: >> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: >> error: >> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) >> uses VFP register arguments, u-boot does not >> >> Which we need to sort out, one way or another. Albert, any quick ideas? > > Builds OK on my side, both nand-flash/master and a merge of nf/master > and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) > > Tom, can you specify which toolchain shows the issue? Both ELDK 5.3 and Linaro 2013.03 (one TI has picked for some things) do the above. ELDK 5.2 is OK - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSVpNMAAoJENk4IS6UOR1WjfMQAKng6alKvCSAfPJ/CMdWqzIW 8bIwtZMrty2Na+d8OYGaq1xnCfztpG1UP75gfxwWRVKoQ8GUMGZz/JzEyER3f4xu WPLQ/PE/AgSdwzllRum2R1PpBJkesG2fdH2KamwxQ78qnQjEM3Pb8Hu6zPoI7adF p1fs+T96ouXrkQqRTpAoZq3NdCWQjNt1/WVTIffTTbNGsUcX4w7H9pdRA/6PTTv+ XPGMtzMTWpZTKBppD6cywiHa2mbFIeXhpWPJwus/xd1roayczYUT+YIhTs5Pe1ie mCNrCZJZu280gynkeoyfCEB98hztKD88fuAPtkrpevuzF9W5kQk15sgNd/ngHltP nktx317JrIAeQcv0WJktxWFCNauSZF7GfdT3p5ZmoV3lbwc63mDmMFc4gb29RuOu iaXbyG186Sfx42ca2uHuYBC5svnHyDzcki9fXuqHAX3fgcyblMUgg8FyWJA9+pFU Y1SEd1dvaa2C56gyKXsW1KXZ3Vbn6hn18AQB/5QZp7dYyXhcoRF/+PkC2uCw6/7P kTuy50sLYBPtdK4Tgzl9s9gIpJYlm03UrdR8gHMr2NyoIoKD/fthfi8MViSQvpGL YN4TUZ/bPobqgMcZ79D0OpTYdssosbe29i+AwlwszlyScnD/BJB3TqH4wo1vCvd9 gfwM3F7xYC5m51uaVxSF =TF80 -----END PGP SIGNATURE-----
Hi Tom, On Thu, 10 Oct 2013 07:45:17 -0400, Tom Rini <trini@ti.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 10/10/2013 04:12 AM, Albert ARIBAUD wrote: > > Hi Tom, > > > > On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: > > > >> On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: > >> > >>> Sorry for the lateness, but here are some MTD/UBI bugfixes. They've > >>> been acked by Stefan Roese. > >>> > >>> The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: > >>> > >>> Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) > >>> > >>> are available in the git repository at: > >>> > >>> git://git.denx.de/u-boot-nand-flash.git master > >>> > >>> for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: > >>> > >>> cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) > >>> > >>> ---------------------------------------------------------------- > >>> Paul Burton (4): > >>> mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > >>> cmd_mtdparts: use 64 bits for flash size, partition size & offset > >>> cmd_ubi: use int64_t volume size for 'ubi create' > >>> cmd_ubi: add write.part command, to write a volume in multiple parts > >> > >> OK, problem: > >> Author: Paul Burton <paul.burton@imgtec.com> > >> Date: Wed Sep 4 15:16:57 2013 +0100 > >> > >> cmd_mtdparts: use 64 bits for flash size, partition size & offset > >> > >> Causes a number of platform such as am3517_crane to fail to build with > >> recent toolchains with errors such as: > >> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: > >> error: > >> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) > >> uses VFP register arguments, u-boot does not > >> > >> Which we need to sort out, one way or another. Albert, any quick ideas? > > > > Builds OK on my side, both nand-flash/master and a merge of nf/master > > and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) > > > > Tom, can you specify which toolchain shows the issue? > > Both ELDK 5.3 and Linaro 2013.03 (one TI has picked for some things) do > the above. ELDK 5.2 is OK I'll test with ELDK5.3 in about an hour. Amicalement,
On Thu, 10 Oct 2013 17:52:14 +0200, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote: > Hi Tom, > > On Thu, 10 Oct 2013 07:45:17 -0400, Tom Rini <trini@ti.com> wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On 10/10/2013 04:12 AM, Albert ARIBAUD wrote: > > > Hi Tom, > > > > > > On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: > > > > > >> On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: > > >> > > >>> Sorry for the lateness, but here are some MTD/UBI bugfixes. They've > > >>> been acked by Stefan Roese. > > >>> > > >>> The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: > > >>> > > >>> Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) > > >>> > > >>> are available in the git repository at: > > >>> > > >>> git://git.denx.de/u-boot-nand-flash.git master > > >>> > > >>> for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: > > >>> > > >>> cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) > > >>> > > >>> ---------------------------------------------------------------- > > >>> Paul Burton (4): > > >>> mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > > >>> cmd_mtdparts: use 64 bits for flash size, partition size & offset > > >>> cmd_ubi: use int64_t volume size for 'ubi create' > > >>> cmd_ubi: add write.part command, to write a volume in multiple parts > > >> > > >> OK, problem: > > >> Author: Paul Burton <paul.burton@imgtec.com> > > >> Date: Wed Sep 4 15:16:57 2013 +0100 > > >> > > >> cmd_mtdparts: use 64 bits for flash size, partition size & offset > > >> > > >> Causes a number of platform such as am3517_crane to fail to build with > > >> recent toolchains with errors such as: > > >> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: > > >> error: > > >> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) > > >> uses VFP register arguments, u-boot does not > > >> > > >> Which we need to sort out, one way or another. Albert, any quick ideas? > > > > > > Builds OK on my side, both nand-flash/master and a merge of nf/master > > > and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) > > > > > > Tom, can you specify which toolchain shows the issue? > > > > Both ELDK 5.3 and Linaro 2013.03 (one TI has picked for some things) do > > the above. ELDK 5.2 is OK > > I'll test with ELDK5.3 in about an hour. I've installed eldk-eglibc-i686-arm-toolchain-gmae-5.3.sh and can build am3517_crane on both nand-flash/master as well as on a merge of u-boot/master and nand-flash/master Amicalement,
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/10/2013 03:00 PM, Albert ARIBAUD wrote: > On Thu, 10 Oct 2013 17:52:14 +0200, Albert ARIBAUD > <albert.u.boot@aribaud.net> wrote: > >> Hi Tom, >> >> On Thu, 10 Oct 2013 07:45:17 -0400, Tom Rini <trini@ti.com> wrote: >> >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> On 10/10/2013 04:12 AM, Albert ARIBAUD wrote: >>>> Hi Tom, >>>> >>>> On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: >>>> >>>>> On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: >>>>> >>>>>> Sorry for the lateness, but here are some MTD/UBI bugfixes. They've >>>>>> been acked by Stefan Roese. >>>>>> >>>>>> The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: >>>>>> >>>>>> Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) >>>>>> >>>>>> are available in the git repository at: >>>>>> >>>>>> git://git.denx.de/u-boot-nand-flash.git master >>>>>> >>>>>> for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: >>>>>> >>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) >>>>>> >>>>>> ---------------------------------------------------------------- >>>>>> Paul Burton (4): >>>>>> mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN >>>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset >>>>>> cmd_ubi: use int64_t volume size for 'ubi create' >>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts >>>>> >>>>> OK, problem: >>>>> Author: Paul Burton <paul.burton@imgtec.com> >>>>> Date: Wed Sep 4 15:16:57 2013 +0100 >>>>> >>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset >>>>> >>>>> Causes a number of platform such as am3517_crane to fail to build with >>>>> recent toolchains with errors such as: >>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: >>>>> error: >>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) >>>>> uses VFP register arguments, u-boot does not >>>>> >>>>> Which we need to sort out, one way or another. Albert, any quick ideas? >>>> >>>> Builds OK on my side, both nand-flash/master and a merge of nf/master >>>> and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) >>>> >>>> Tom, can you specify which toolchain shows the issue? >>> >>> Both ELDK 5.3 and Linaro 2013.03 (one TI has picked for some things) do >>> the above. ELDK 5.2 is OK >> >> I'll test with ELDK5.3 in about an hour. > > I've installed eldk-eglibc-i686-arm-toolchain-gmae-5.3.sh and can build > am3517_crane on both nand-flash/master as well as on a merge of > u-boot/master and nand-flash/master Here we go, armhf toolchains trigger this problem because, I suspect, we aren't enforcing a flag to say "no, really, no hfp here" or similar. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSVv2SAAoJENk4IS6UOR1WztMP/2I4Ir49kekF8gsna8b+h5xz EXXBTmkSPCok3H3ZCW6iRDrBCpwz6kdzTPt6svLGOQtbUZnTavrZhSsbe4dtxJb8 PrxHpdSNiV8TQ39DAnmlgAvw8W5ve/+Ck9h+OB9WyCMk4I15KElPYcU4/Pw3ICRo W6dbVD8jQcMr26UwfFz4zgMcBgIg7c7zeAMsRBuOOxZRE3fx2e2Ze2IXnNrSnsFW 7eYuEetNWflwrwRXZAF+05o7KHxSMh+Hh5V9nefXfRQ/rpbUOptZBdABkL9D/TKa nY+pi3B1AsLgcTvZfr8fdJQORQaAuvhPPhtb8bjSVOr8EBePHJ+DdYrSjbUK183N aHZVum+aPooPXFxc/f1zlreJqE3NMh8s1Q5kR+A2L8lbnOS6uSBZMPXIiR6WL464 mDSs3hd9g3lHcSMMdRBBtKMGH0wPbIL8chlHgh7+UrmlNWPsCWIeZfe+6i8pXd5h UgeOCHqkbfd0tRQ3xBnnnh6+ypvjbK3EGTtJ3cD1XSdv//EjgXlB01IpFbP0jdTv eaZYoQAGtkhz+rlQEkv+gnPyRu7qvt5pJDm71pcf6Xwzd839TRgpNejCR9AIs43Q dx0Dvd5iMaMv+/m4q7w+XFQssqsdsWX/Etfln20Rtt+H6zr6RpRzt8xLV6A6JIn7 zu72g3MEMwbtVA/z9Hrr =A2x5 -----END PGP SIGNATURE-----
On Thu, 2013-10-10 at 15:18 -0400, Tom Rini wrote: > On 10/10/2013 03:00 PM, Albert ARIBAUD wrote: > > On Thu, 10 Oct 2013 17:52:14 +0200, Albert ARIBAUD > > <albert.u.boot@aribaud.net> wrote: > > > >> Hi Tom, > >> > >> On Thu, 10 Oct 2013 07:45:17 -0400, Tom Rini <trini@ti.com> wrote: > >> > >>> -----BEGIN PGP SIGNED MESSAGE----- > >>> Hash: SHA1 > >>> > >>> On 10/10/2013 04:12 AM, Albert ARIBAUD wrote: > >>>> Hi Tom, > >>>> > >>>> On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: > >>>> > >>>>> On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: > >>>>> > >>>>>> Sorry for the lateness, but here are some MTD/UBI bugfixes. They've > >>>>>> been acked by Stefan Roese. > >>>>>> > >>>>>> The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: > >>>>>> > >>>>>> Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) > >>>>>> > >>>>>> are available in the git repository at: > >>>>>> > >>>>>> git://git.denx.de/u-boot-nand-flash.git master > >>>>>> > >>>>>> for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: > >>>>>> > >>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) > >>>>>> > >>>>>> ---------------------------------------------------------------- > >>>>>> Paul Burton (4): > >>>>>> mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > >>>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset > >>>>>> cmd_ubi: use int64_t volume size for 'ubi create' > >>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts > >>>>> > >>>>> OK, problem: > >>>>> Author: Paul Burton <paul.burton@imgtec.com> > >>>>> Date: Wed Sep 4 15:16:57 2013 +0100 > >>>>> > >>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset > >>>>> > >>>>> Causes a number of platform such as am3517_crane to fail to build with > >>>>> recent toolchains with errors such as: > >>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: > >>>>> error: > >>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) > >>>>> uses VFP register arguments, u-boot does not > >>>>> > >>>>> Which we need to sort out, one way or another. Albert, any quick ideas? > >>>> > >>>> Builds OK on my side, both nand-flash/master and a merge of nf/master > >>>> and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) > >>>> > >>>> Tom, can you specify which toolchain shows the issue? > >>> > >>> Both ELDK 5.3 and Linaro 2013.03 (one TI has picked for some things) do > >>> the above. ELDK 5.2 is OK > >> > >> I'll test with ELDK5.3 in about an hour. > > > > I've installed eldk-eglibc-i686-arm-toolchain-gmae-5.3.sh and can build > > am3517_crane on both nand-flash/master as well as on a merge of > > u-boot/master and nand-flash/master > > Here we go, armhf toolchains trigger this problem because, I suspect, we > aren't enforcing a flag to say "no, really, no hfp here" or similar. Any idea why this patchset triggers it? Does the 64-bit stuff cause something from libgcc to be used that previously wasn't? There is some open-coded 64-bit division, but it's by a power of two so GCC should convert it to a shift (and the ability to do 64-bit shifts was already required by print_size()). -Scott
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/10/2013 06:10 PM, Scott Wood wrote: > On Thu, 2013-10-10 at 15:18 -0400, Tom Rini wrote: >> On 10/10/2013 03:00 PM, Albert ARIBAUD wrote: >>> On Thu, 10 Oct 2013 17:52:14 +0200, Albert ARIBAUD >>> <albert.u.boot@aribaud.net> wrote: >>> >>>> Hi Tom, >>>> >>>> On Thu, 10 Oct 2013 07:45:17 -0400, Tom Rini <trini@ti.com> wrote: >>>> >>>>> -----BEGIN PGP SIGNED MESSAGE----- >>>>> Hash: SHA1 >>>>> >>>>> On 10/10/2013 04:12 AM, Albert ARIBAUD wrote: >>>>>> Hi Tom, >>>>>> >>>>>> On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: >>>>>> >>>>>>> On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: >>>>>>> >>>>>>>> Sorry for the lateness, but here are some MTD/UBI bugfixes. They've >>>>>>>> been acked by Stefan Roese. >>>>>>>> >>>>>>>> The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: >>>>>>>> >>>>>>>> Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) >>>>>>>> >>>>>>>> are available in the git repository at: >>>>>>>> >>>>>>>> git://git.denx.de/u-boot-nand-flash.git master >>>>>>>> >>>>>>>> for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: >>>>>>>> >>>>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) >>>>>>>> >>>>>>>> ---------------------------------------------------------------- >>>>>>>> Paul Burton (4): >>>>>>>> mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN >>>>>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset >>>>>>>> cmd_ubi: use int64_t volume size for 'ubi create' >>>>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts >>>>>>> >>>>>>> OK, problem: >>>>>>> Author: Paul Burton <paul.burton@imgtec.com> >>>>>>> Date: Wed Sep 4 15:16:57 2013 +0100 >>>>>>> >>>>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset >>>>>>> >>>>>>> Causes a number of platform such as am3517_crane to fail to build with >>>>>>> recent toolchains with errors such as: >>>>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: >>>>>>> error: >>>>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) >>>>>>> uses VFP register arguments, u-boot does not >>>>>>> >>>>>>> Which we need to sort out, one way or another. Albert, any quick ideas? >>>>>> >>>>>> Builds OK on my side, both nand-flash/master and a merge of nf/master >>>>>> and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) >>>>>> >>>>>> Tom, can you specify which toolchain shows the issue? >>>>> >>>>> Both ELDK 5.3 and Linaro 2013.03 (one TI has picked for some things) do >>>>> the above. ELDK 5.2 is OK >>>> >>>> I'll test with ELDK5.3 in about an hour. >>> >>> I've installed eldk-eglibc-i686-arm-toolchain-gmae-5.3.sh and can build >>> am3517_crane on both nand-flash/master as well as on a merge of >>> u-boot/master and nand-flash/master >> >> Here we go, armhf toolchains trigger this problem because, I suspect, we >> aren't enforcing a flag to say "no, really, no hfp here" or similar. > > Any idea why this patchset triggers it? Does the 64-bit stuff cause > something from libgcc to be used that previously wasn't? There is some > open-coded 64-bit division, but it's by a power of two so GCC should > convert it to a shift (and the ability to do 64-bit shifts was already > required by print_size()). I'm not sure what parts of this math exactly cause things to go all nutty, but I suspect the answer is that we should be enforcing - -msomething or another than hf defaults to using (un)setting. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSVy/JAAoJENk4IS6UOR1WgyIP+gIIF7gvWREeqfbtxt0jktj3 cDc0VsT5FHoIK7qVAmOxhRP7yhN62sSkQJJ8D8b71Vequ5bTiuuDlSs1qml6Rb2F bD4ivDCRSK/7RuE13XJOgSuUnhSEbXdWS5b5WzpHD4r9t+IM6vF03FVBx6Ob4h+Q x8jBZlNjDT+wmDmuSRhN0opIDmhj1+mPt66fkXap/ZsAqyNfHfyWdFIfnprH4JxT RYrtP57vPTELwSQJJY0IOYAw8y/JgMiOO4zkrh6AO87dwZtoRi3M2eV18qcEYjvz g9rHdXMpoaxIecicDgDY4Lnr0XT7phyKaFV1ZEUKxdC1CA1Lsc+LRsuAJFr1s6wB QZZH9ckmJgeYWRmF6jP5qpDCVzzBkZn5D0Nq5gOrkcbaPVNpUQ9//7aEiwWLULDu rhas3MrT+m1MD8OO6LTZG5zn3MYhm8Ih7NHLFOp7W+AZuZlZorjW/+XLHe+UWtKU caExJ4+zXOOjUl7Tz3EWEVBdpM3ikYleHTD/pFbMyP9PpR/Y0o6H8X7VU/Xz8L9v AnkCWdlhavD9NMAIAj/4PuyVTPjUIDWIH7CCk4UcrgFSJaXWQX+2sPIkE+IgiVO4 Cd9UvEsFVcY82uvbWSXLdx/lfa9uIhBqz7JGcseB6Ch20elWrv0uqpGTmPJm5J+d bpdD+ilktDFpS857eMyW =BKAP -----END PGP SIGNATURE-----
On Wed, Oct 9, 2013 at 3:29 PM, Scott Wood <scottwood@freescale.com> wrote: > Paul Burton (4): > mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > cmd_mtdparts: use 64 bits for flash size, partition size & offset > cmd_ubi: use int64_t volume size for 'ubi create' > cmd_ubi: add write.part command, to write a volume in multiple parts This fixed the problem I had with UBI using 4G NAND in mx28evk :-) http://patchwork.ozlabs.org/patch/280283/ This is the missing fix to get 4G NAND working fine on it. I have some environment changes pending but will send it later tomorrow (for next).
Hi Tom, On Thu, 10 Oct 2013 18:52:57 -0400, Tom Rini <trini@ti.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 10/10/2013 06:10 PM, Scott Wood wrote: > > On Thu, 2013-10-10 at 15:18 -0400, Tom Rini wrote: > >> On 10/10/2013 03:00 PM, Albert ARIBAUD wrote: > >>> On Thu, 10 Oct 2013 17:52:14 +0200, Albert ARIBAUD > >>> <albert.u.boot@aribaud.net> wrote: > >>> > >>>> Hi Tom, > >>>> > >>>> On Thu, 10 Oct 2013 07:45:17 -0400, Tom Rini <trini@ti.com> wrote: > >>>> > >>>>> -----BEGIN PGP SIGNED MESSAGE----- > >>>>> Hash: SHA1 > >>>>> > >>>>> On 10/10/2013 04:12 AM, Albert ARIBAUD wrote: > >>>>>> Hi Tom, > >>>>>> > >>>>>> On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: > >>>>>> > >>>>>>> On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: > >>>>>>> > >>>>>>>> Sorry for the lateness, but here are some MTD/UBI bugfixes. They've > >>>>>>>> been acked by Stefan Roese. > >>>>>>>> > >>>>>>>> The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: > >>>>>>>> > >>>>>>>> Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) > >>>>>>>> > >>>>>>>> are available in the git repository at: > >>>>>>>> > >>>>>>>> git://git.denx.de/u-boot-nand-flash.git master > >>>>>>>> > >>>>>>>> for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: > >>>>>>>> > >>>>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) > >>>>>>>> > >>>>>>>> ---------------------------------------------------------------- > >>>>>>>> Paul Burton (4): > >>>>>>>> mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > >>>>>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset > >>>>>>>> cmd_ubi: use int64_t volume size for 'ubi create' > >>>>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts > >>>>>>> > >>>>>>> OK, problem: > >>>>>>> Author: Paul Burton <paul.burton@imgtec.com> > >>>>>>> Date: Wed Sep 4 15:16:57 2013 +0100 > >>>>>>> > >>>>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset > >>>>>>> > >>>>>>> Causes a number of platform such as am3517_crane to fail to build with > >>>>>>> recent toolchains with errors such as: > >>>>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: > >>>>>>> error: > >>>>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) > >>>>>>> uses VFP register arguments, u-boot does not > >>>>>>> > >>>>>>> Which we need to sort out, one way or another. Albert, any quick ideas? > >>>>>> > >>>>>> Builds OK on my side, both nand-flash/master and a merge of nf/master > >>>>>> and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) > >>>>>> > >>>>>> Tom, can you specify which toolchain shows the issue? > >>>>> > >>>>> Both ELDK 5.3 and Linaro 2013.03 (one TI has picked for some things) do > >>>>> the above. ELDK 5.2 is OK > >>>> > >>>> I'll test with ELDK5.3 in about an hour. > >>> > >>> I've installed eldk-eglibc-i686-arm-toolchain-gmae-5.3.sh and can build > >>> am3517_crane on both nand-flash/master as well as on a merge of > >>> u-boot/master and nand-flash/master > >> > >> Here we go, armhf toolchains trigger this problem because, I suspect, we > >> aren't enforcing a flag to say "no, really, no hfp here" or similar. > > > > Any idea why this patchset triggers it? Does the 64-bit stuff cause > > something from libgcc to be used that previously wasn't? There is some > > open-coded 64-bit division, but it's by a power of two so GCC should > > convert it to a shift (and the ability to do 64-bit shifts was already > > required by print_size()). > > I'm not sure what parts of this math exactly cause things to go all > nutty, but I suspect the answer is that we should be enforcing > - -msomething or another than hf defaults to using (un)setting. Ok, trying with the ARMhf toolchain. Amicalement,
On Fri, 11 Oct 2013 09:11:52 +0200, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote: > Hi Tom, > > On Thu, 10 Oct 2013 18:52:57 -0400, Tom Rini <trini@ti.com> wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On 10/10/2013 06:10 PM, Scott Wood wrote: > > > On Thu, 2013-10-10 at 15:18 -0400, Tom Rini wrote: > > >> On 10/10/2013 03:00 PM, Albert ARIBAUD wrote: > > >>> On Thu, 10 Oct 2013 17:52:14 +0200, Albert ARIBAUD > > >>> <albert.u.boot@aribaud.net> wrote: > > >>> > > >>>> Hi Tom, > > >>>> > > >>>> On Thu, 10 Oct 2013 07:45:17 -0400, Tom Rini <trini@ti.com> wrote: > > >>>> > > >>>>> -----BEGIN PGP SIGNED MESSAGE----- > > >>>>> Hash: SHA1 > > >>>>> > > >>>>> On 10/10/2013 04:12 AM, Albert ARIBAUD wrote: > > >>>>>> Hi Tom, > > >>>>>> > > >>>>>> On Wed, 9 Oct 2013 21:45:25 -0400, Tom Rini <trini@ti.com> wrote: > > >>>>>> > > >>>>>>> On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: > > >>>>>>> > > >>>>>>>> Sorry for the lateness, but here are some MTD/UBI bugfixes. They've > > >>>>>>>> been acked by Stefan Roese. > > >>>>>>>> > > >>>>>>>> The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: > > >>>>>>>> > > >>>>>>>> Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) > > >>>>>>>> > > >>>>>>>> are available in the git repository at: > > >>>>>>>> > > >>>>>>>> git://git.denx.de/u-boot-nand-flash.git master > > >>>>>>>> > > >>>>>>>> for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: > > >>>>>>>> > > >>>>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) > > >>>>>>>> > > >>>>>>>> ---------------------------------------------------------------- > > >>>>>>>> Paul Burton (4): > > >>>>>>>> mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > > >>>>>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset > > >>>>>>>> cmd_ubi: use int64_t volume size for 'ubi create' > > >>>>>>>> cmd_ubi: add write.part command, to write a volume in multiple parts > > >>>>>>> > > >>>>>>> OK, problem: > > >>>>>>> Author: Paul Burton <paul.burton@imgtec.com> > > >>>>>>> Date: Wed Sep 4 15:16:57 2013 +0100 > > >>>>>>> > > >>>>>>> cmd_mtdparts: use 64 bits for flash size, partition size & offset > > >>>>>>> > > >>>>>>> Causes a number of platform such as am3517_crane to fail to build with > > >>>>>>> recent toolchains with errors such as: > > >>>>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-ld.bfd: > > >>>>>>> error: > > >>>>>>> /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/../lib/gcc/arm-linux-gnueabihf/4.7.3/libgcc.a(bpabi.o) > > >>>>>>> uses VFP register arguments, u-boot does not > > >>>>>>> > > >>>>>>> Which we need to sort out, one way or another. Albert, any quick ideas? > > >>>>>> > > >>>>>> Builds OK on my side, both nand-flash/master and a merge of nf/master > > >>>>>> and u-boot/master, with gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1) > > >>>>>> > > >>>>>> Tom, can you specify which toolchain shows the issue? > > >>>>> > > >>>>> Both ELDK 5.3 and Linaro 2013.03 (one TI has picked for some things) do > > >>>>> the above. ELDK 5.2 is OK > > >>>> > > >>>> I'll test with ELDK5.3 in about an hour. > > >>> > > >>> I've installed eldk-eglibc-i686-arm-toolchain-gmae-5.3.sh and can build > > >>> am3517_crane on both nand-flash/master as well as on a merge of > > >>> u-boot/master and nand-flash/master > > >> > > >> Here we go, armhf toolchains trigger this problem because, I suspect, we > > >> aren't enforcing a flag to say "no, really, no hfp here" or similar. > > > > > > Any idea why this patchset triggers it? Does the 64-bit stuff cause > > > something from libgcc to be used that previously wasn't? There is some > > > open-coded 64-bit division, but it's by a power of two so GCC should > > > convert it to a shift (and the ability to do 64-bit shifts was already > > > required by print_size()). > > > > I'm not sure what parts of this math exactly cause things to go all > > nutty, but I suspect the answer is that we should be enforcing > > - -msomething or another than hf defaults to using (un)setting. > > Ok, trying with the ARMhf toolchain. Even using the gnueabihf ELDK 5.3 toolchain, I still can build am3517_crane with no problem. Amicalement,
On Wed, Oct 09, 2013 at 01:29:55PM -0500, Scott Wood wrote: > Sorry for the lateness, but here are some MTD/UBI bugfixes. They've > been acked by Stefan Roese. > > The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: > > Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-nand-flash.git master > > for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: > > cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) > > ---------------------------------------------------------------- > Paul Burton (4): > mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN > cmd_mtdparts: use 64 bits for flash size, partition size & offset > cmd_ubi: use int64_t volume size for 'ubi create' > cmd_ubi: add write.part command, to write a volume in multiple parts > > common/cmd_mtdparts.c | 54 ++++++++++++++------------ > common/cmd_ubi.c | 79 +++++++++++++++++++++++++++----------- > doc/README.ubi | 3 ++ > drivers/mtd/mtdcore.c | 14 ++++++- > drivers/mtd/mtdpart.c | 12 +++--- > drivers/mtd/nand/nand_base.c | 18 +++++++-- > drivers/mtd/onenand/onenand_base.c | 3 +- > include/jffs2/load_kernel.h | 6 +-- > include/linux/mtd/nand.h | 3 ++ > 9 files changed, 129 insertions(+), 63 deletions(-) Applied to u-boot/master, thanks!
Sorry for the lateness, but here are some MTD/UBI bugfixes. They've been acked by Stefan Roese. The following changes since commit b770e88a6c2548727f0d57a3e9e8bb0830f977b5: Fix number base handling of "load" command (2013-10-07 15:54:18 -0400) are available in the git repository at: git://git.denx.de/u-boot-nand-flash.git master for you to fetch changes up to cc734f5ab26134e5e8d57c34edc257c89ac5b1d2: cmd_ubi: add write.part command, to write a volume in multiple parts (2013-10-09 12:52:22 -0500) ---------------------------------------------------------------- Paul Burton (4): mtd: driver _read() returns max_bitflips; mtd_read() returns -EUCLEAN cmd_mtdparts: use 64 bits for flash size, partition size & offset cmd_ubi: use int64_t volume size for 'ubi create' cmd_ubi: add write.part command, to write a volume in multiple parts common/cmd_mtdparts.c | 54 ++++++++++++++------------ common/cmd_ubi.c | 79 +++++++++++++++++++++++++++----------- doc/README.ubi | 3 ++ drivers/mtd/mtdcore.c | 14 ++++++- drivers/mtd/mtdpart.c | 12 +++--- drivers/mtd/nand/nand_base.c | 18 +++++++-- drivers/mtd/onenand/onenand_base.c | 3 +- include/jffs2/load_kernel.h | 6 +-- include/linux/mtd/nand.h | 3 ++ 9 files changed, 129 insertions(+), 63 deletions(-)