diff mbox

[U-Boot] Makefile: Do not show make debug messages

Message ID 1379473287-31492-1-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Sept. 18, 2013, 3:01 a.m. UTC
In commit 27af930, the top Makefile was adjusted to the new
boards.cfg format.

But at the same time, -d option was added.

If you configure and make separately, for example
like follows:

    make omap4_panda_config
    make CROSS_COMPILE=<your_compiler_prefix>

it works fine as it did before.

But if you do them in one time like follows:

    make omap4_panda CROSS_COMPILE=<your_compiler_prefix>

The log is sprinkled with annoying make debug messages.

This commit deletes -d option again.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nishanth Menon Sept. 19, 2013, 1 p.m. UTC | #1
On 09/17/2013 10:01 PM, Masahiro Yamada wrote:
> In commit 27af930, the top Makefile was adjusted to the new
> boards.cfg format.
> 
> But at the same time, -d option was added.
> 
> If you configure and make separately, for example
> like follows:
> 
>     make omap4_panda_config
>     make CROSS_COMPILE=<your_compiler_prefix>
> 
> it works fine as it did before.
> 
> But if you do them in one time like follows:
> 
>     make omap4_panda CROSS_COMPILE=<your_compiler_prefix>
> 
> The log is sprinkled with annoying make debug messages.
> 
> This commit deletes -d option again.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 28ddb7e..bc639b3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -838,7 +838,7 @@ unconfig:
>  
>  sinclude $(obj).boards.depend
>  $(obj).boards.depend:	boards.cfg
> -	@awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@
> +	@awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE)" }' $< > $@
>  
>  #
>  # Functions to generate common board directory names
> 

Thanks - this helped me.

Before log: http://pastebin.com/92HdiQdP
After log: http://pastebin.com/7UnYdajd

Tested-by: Nishanth Menon  <nm@ti.com>
Nishanth Menon Sept. 19, 2013, 1:41 p.m. UTC | #2
On 09/19/2013 08:00 AM, Nishanth Menon wrote:
> On 09/17/2013 10:01 PM, Masahiro Yamada wrote:
>> In commit 27af930, the top Makefile was adjusted to the new
>> boards.cfg format.
>>
>> But at the same time, -d option was added.
>>
>> If you configure and make separately, for example
>> like follows:
>>
>>     make omap4_panda_config
>>     make CROSS_COMPILE=<your_compiler_prefix>
>>
>> it works fine as it did before.
>>
>> But if you do them in one time like follows:
>>
>>     make omap4_panda CROSS_COMPILE=<your_compiler_prefix>
>>
>> The log is sprinkled with annoying make debug messages.
>>
>> This commit deletes -d option again.
>>
>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>> ---
>>  Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 28ddb7e..bc639b3 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -838,7 +838,7 @@ unconfig:
>>  
>>  sinclude $(obj).boards.depend
>>  $(obj).boards.depend:	boards.cfg
>> -	@awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@
>> +	@awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE)" }' $< > $@
>>  
>>  #
>>  # Functions to generate common board directory names
>>
> 
> Thanks - this helped me.
> 
> Before log: http://pastebin.com/92HdiQdP
> After log: http://pastebin.com/7UnYdajd
> 
> Tested-by: Nishanth Menon  <nm@ti.com>
> 

just a side note: if one has already tried building,
git clean -fdx
helps remove the mess..
Tom Rini Sept. 21, 2013, 12:07 p.m. UTC | #3
On Wed, Sep 18, 2013 at 12:01:27PM +0900, Masahiro Yamada wrote:

> In commit 27af930, the top Makefile was adjusted to the new
> boards.cfg format.
> 
> But at the same time, -d option was added.
> 
> If you configure and make separately, for example
> like follows:
> 
>     make omap4_panda_config
>     make CROSS_COMPILE=<your_compiler_prefix>
> 
> it works fine as it did before.
> 
> But if you do them in one time like follows:
> 
>     make omap4_panda CROSS_COMPILE=<your_compiler_prefix>
> 
> The log is sprinkled with annoying make debug messages.
> 
> This commit deletes -d option again.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Tested-by: Nishanth Menon  <nm@ti.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 28ddb7e..bc639b3 100644
--- a/Makefile
+++ b/Makefile
@@ -838,7 +838,7 @@  unconfig:
 
 sinclude $(obj).boards.depend
 $(obj).boards.depend:	boards.cfg
-	@awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE) -d" }' $< > $@
+	@awk '(NF && $$1 !~ /^#/) { print $$7 ": " $$7 "_config; $$(MAKE)" }' $< > $@
 
 #
 # Functions to generate common board directory names