| Message ID | 1241640919-4650-5-git-send-email-wd@denx.de (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Grant Likely |
| Headers | show |
Wolfgang Denk wrote: > From: Piotr Ziecik <kosmo@semihalf.com> > > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: John Rigby <jcrigby@gmail.com> > --- > arch/powerpc/include/asm/mpc512x.h | 13 +++++++++++++ > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/include/asm/mpc512x.h b/arch/powerpc/include/asm/mpc512x.h > index c48a165..ea50d8d 100644 > --- a/arch/powerpc/include/asm/mpc512x.h > +++ b/arch/powerpc/include/asm/mpc512x.h > @@ -16,6 +16,19 @@ > #ifndef __ASM_POWERPC_MPC512x_H__ > #define __ASM_POWERPC_MPC512x_H__ > > +/* MPC512x Reset module registers */ > +struct mpc512x_reset_module { > + u32 rcwlr; /* Reset Configuration Word Low Register */ > + u32 rcwhr; /* Reset Configuration Word High Register */ > + u32 reserved1; > + u32 reserved2; > + u32 rsr; /* Reset Status Register */ > + u32 rmr; /* Reset Mode Register */ > + u32 rpr; /* Reset Protection Register */ > + u32 rcr; /* Reset Control Register */ > + u32 rcer; /* Reset Control Enable Register */ > +} __attribute__ ((__packed__)); > + 83xx has the same registers; we should define it in a non-512x-specific header. -Scott
On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote: > From: Piotr Ziecik <kosmo@semihalf.com> > > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: John Rigby <jcrigby@gmail.com> No patch description. I would also like to see this patch merged with the actual user of it since it is so small. > --- > arch/powerpc/include/asm/mpc512x.h | 13 +++++++++++++ > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/include/asm/mpc512x.h b/arch/powerpc/include/asm/mpc512x.h > index c48a165..ea50d8d 100644 > --- a/arch/powerpc/include/asm/mpc512x.h > +++ b/arch/powerpc/include/asm/mpc512x.h > @@ -16,6 +16,19 @@ > #ifndef __ASM_POWERPC_MPC512x_H__ > #define __ASM_POWERPC_MPC512x_H__ > > +/* MPC512x Reset module registers */ > +struct mpc512x_reset_module { > + u32 rcwlr; /* Reset Configuration Word Low Register */ > + u32 rcwhr; /* Reset Configuration Word High Register */ > + u32 reserved1; > + u32 reserved2; > + u32 rsr; /* Reset Status Register */ > + u32 rmr; /* Reset Mode Register */ > + u32 rpr; /* Reset Protection Register */ > + u32 rcr; /* Reset Control Register */ > + u32 rcer; /* Reset Control Enable Register */ > +} __attribute__ ((__packed__)); __attribute__((__packed__)); is unnecessary. g.
Dear Scott, in message <4A01F33B.2090100@freescale.com> you wrote: > > > --- a/arch/powerpc/include/asm/mpc512x.h > > +++ b/arch/powerpc/include/asm/mpc512x.h ... > 83xx has the same registers; we should define it in a non-512x-specific > header. Agreed. Any suggestion where? Best regards, Wolfgang Denk
Dear Grant Likely, In message <fa686aa40905061339u171559b8va45c210b3e63cf83@mail.gmail.com> you wrote: > > No patch description. I would also like to see this patch merged with > the actual user of it since it is so small. Will do. As for description - the Subject says it all. > > +} __attribute__ ((__packed__)); > > __attribute__((__packed__)); is unnecessary. OK. Best regards, Wolfgang Denk
diff --git a/arch/powerpc/include/asm/mpc512x.h b/arch/powerpc/include/asm/mpc512x.h index c48a165..ea50d8d 100644 --- a/arch/powerpc/include/asm/mpc512x.h +++ b/arch/powerpc/include/asm/mpc512x.h @@ -16,6 +16,19 @@ #ifndef __ASM_POWERPC_MPC512x_H__ #define __ASM_POWERPC_MPC512x_H__ +/* MPC512x Reset module registers */ +struct mpc512x_reset_module { + u32 rcwlr; /* Reset Configuration Word Low Register */ + u32 rcwhr; /* Reset Configuration Word High Register */ + u32 reserved1; + u32 reserved2; + u32 rsr; /* Reset Status Register */ + u32 rmr; /* Reset Mode Register */ + u32 rpr; /* Reset Protection Register */ + u32 rcr; /* Reset Control Register */ + u32 rcer; /* Reset Control Enable Register */ +} __attribute__ ((__packed__)); + extern unsigned long mpc512x_find_ips_freq(struct device_node *node); #endif /* __ASM_POWERPC_MPC512x_H__ */