| Message ID | 1374944196-19580-1-git-send-email-tjlee@ambarella.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Tzu-Jung Lee, On Sat, Jul 27, 2013 at 6:56 PM, Tzu-Jung Lee <roylee17@gmail.com> wrote: > One of the use cases is for the 'local packages' to restore > the SCM info. Some packages use this information to generate > version info during build time. In this case, the local package > can have this hook to restore it by symbolic link for example. > > Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> > --- > package/pkg-generic.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk > index d9a12f2..06e865d 100644 > --- a/package/pkg-generic.mk > +++ b/package/pkg-generic.mk > @@ -63,6 +63,7 @@ $(BUILD_DIR)/%/.stamp_rsynced: > @$(call MESSAGE,"Syncing from source dir $(SRCDIR)") > @test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1) > rsync -au --cvs-exclude --include core $(SRCDIR)/ $(@D) > + $(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep)) > $(Q)touch $@ > > # Handle the SOURCE_CHECK and SHOW_EXTERNAL_DEPS cases for rsynced I think you should update the documentation to mention this hook. Also, further in pkg-generic.mk is a list of all hooks defaulting to empty. You should add the new POST_RSYNC_HOOK there as well. Best regards, Thomas
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index d9a12f2..06e865d 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -63,6 +63,7 @@ $(BUILD_DIR)/%/.stamp_rsynced: @$(call MESSAGE,"Syncing from source dir $(SRCDIR)") @test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1) rsync -au --cvs-exclude --include core $(SRCDIR)/ $(@D) + $(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep)) $(Q)touch $@ # Handle the SOURCE_CHECK and SHOW_EXTERNAL_DEPS cases for rsynced
One of the use cases is for the 'local packages' to restore the SCM info. Some packages use this information to generate version info during build time. In this case, the local package can have this hook to restore it by symbolic link for example. Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> --- package/pkg-generic.mk | 1 + 1 file changed, 1 insertion(+)