diff mbox

[U-Boot] arm:samsung:trats:fix: Restore proper orientation of TRATS's LCD panel

Message ID 1373897390-28671-1-git-send-email-l.majewski@samsung.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Łukasz Majewski July 15, 2013, 2:09 p.m. UTC 
Before setting: mipi_lcd_device.reverse_panel = 1, the Trats's LCD panel
was flipped by 180 degrees.

The flip was caused by following change:
Exynos: Change get_timer() to work correctly
SHA1: 3d00c0cb96ff93a929700b80d89cb905e5ab5315

This commit fixed udelay(), which is necessary (due to HW LCD controller 
oddity) for mipi-dsi correct operation. As a result the display orientation
has been switched.

As a follow up, the hwrevision() function has been removed, since it was
used only in this particular place.

Test HW: Trats Exynos4210 rev 0.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
---
 board/samsung/trats/trats.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Minkyu Kang July 16, 2013, 1:23 a.m. UTC | #1 
Dear Tom,

On 15/07/13 23:09, Lukasz Majewski wrote:
> Before setting: mipi_lcd_device.reverse_panel = 1, the Trats's LCD panel
> was flipped by 180 degrees.
> 
> The flip was caused by following change:
> Exynos: Change get_timer() to work correctly
> SHA1: 3d00c0cb96ff93a929700b80d89cb905e5ab5315
> 
> This commit fixed udelay(), which is necessary (due to HW LCD controller 
> oddity) for mipi-dsi correct operation. As a result the display orientation
> has been switched.
> 
> As a follow up, the hwrevision() function has been removed, since it was
> used only in this particular place.
> 
> Test HW: Trats Exynos4210 rev 0.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  board/samsung/trats/trats.c |   10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 

Acked-by: Minkyu Kang <mk7.kang@samsung.com>

Thanks,
Minkyu Kang.
Tom Rini July 16, 2013, 2:37 p.m. UTC | #2 
On Mon, Jul 15, 2013 at 04:09:50PM +0200, ??ukasz Majewski wrote:

> Before setting: mipi_lcd_device.reverse_panel = 1, the Trats's LCD panel
> was flipped by 180 degrees.
> 
> The flip was caused by following change:
> Exynos: Change get_timer() to work correctly
> SHA1: 3d00c0cb96ff93a929700b80d89cb905e5ab5315
> 
> This commit fixed udelay(), which is necessary (due to HW LCD controller 
> oddity) for mipi-dsi correct operation. As a result the display orientation
> has been switched.
> 
> As a follow up, the hwrevision() function has been removed, since it was
> used only in this particular place.
> 
> Test HW: Trats Exynos4210 rev 0.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Acked-by: Minkyu Kang <mk7.kang@samsung.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index e20fb3d..71fe767 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -58,12 +58,6 @@  u32 get_board_rev(void)
 #endif
 
 static void check_hw_revision(void);
-
-static int hwrevision(int rev)
-{
-	return (board_rev & 0xf) == rev;
-}
-
 struct s3c_plat_otg_data s5pc210_otg_data;
 
 int board_init(void)
@@ -773,9 +767,7 @@  void init_panel_info(vidinfo_t *vid)
 #ifdef CONFIG_TIZEN
 	get_tizen_logo_info(vid);
 #endif
-
-	if (hwrevision(2))
-		mipi_lcd_device.reverse_panel = 1;
+	mipi_lcd_device.reverse_panel = 1;
 
 	strcpy(s6e8ax0_platform_data.lcd_panel_name, mipi_lcd_device.name);
 	s6e8ax0_platform_data.lcd_power = lcd_power;