Message ID | 20090410082910.14372.22207.stgit@localhost.localdomain |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Date: Fri, 10 Apr 2009 01:29:10 -0700 > GCC warns: > drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task': > drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around > operand of '!' or change '&' to '&&' or '!' to '~' > > Which I think is right. Bracket to remove ambiguity. > > Signed-off-by: Tony Breeds <tony@bakeyournoodle.com> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Applied to net-next-2.6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 2856486..813c5bc 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work) } hw->mac.ops.setup_sfp(hw); - if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK) + if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)) /* This will also work for DA Twinax connections */ schedule_work(&adapter->multispeed_fiber_task); adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;