From patchwork Fri Apr 10 08:29:10 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirsher, Jeffrey T" X-Patchwork-Id: 25846 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id D7419DE1D1 for ; Sat, 11 Apr 2009 02:57:49 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938784AbZDJQ5l (ORCPT ); Fri, 10 Apr 2009 12:57:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S938774AbZDJQ5k (ORCPT ); Fri, 10 Apr 2009 12:57:40 -0400 Received: from qmta07.westchester.pa.mail.comcast.net ([76.96.62.64]:55251 "EHLO QMTA07.westchester.pa.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938720AbZDJQ5j (ORCPT ); Fri, 10 Apr 2009 12:57:39 -0400 Received: from OMTA11.westchester.pa.mail.comcast.net ([76.96.62.36]) by QMTA07.westchester.pa.mail.comcast.net with comcast id dqPu1b01M0mv7h057sxFHJ; Fri, 10 Apr 2009 16:57:15 +0000 Received: from localhost.localdomain ([63.64.152.142]) by OMTA11.westchester.pa.mail.comcast.net with comcast id dsxM1b00L34bfcX3XsxPnh; Fri, 10 Apr 2009 16:57:36 +0000 From: Jeff Kirsher Subject: [PATCH 10/10] Be explict with what we are !'ing in ixgbe_sfp_config_module_task() To: davem@davemloft.net Cc: netdev@vger.kernel.org, gospo@redhat.com, Tony Breeds , Jeff Kirsher Date: Fri, 10 Apr 2009 01:29:10 -0700 Message-ID: <20090410082910.14372.22207.stgit@localhost.localdomain> In-Reply-To: <20090410082618.14372.86091.stgit@localhost.localdomain> References: <20090410082618.14372.86091.stgit@localhost.localdomain> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tony Breeds GCC warns: drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task': drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around operand of '!' or change '&' to '&&' or '!' to '~' Which I think is right. Bracket to remove ambiguity. Signed-off-by: Tony Breeds Signed-off-by: Jeff Kirsher --- drivers/net/ixgbe/ixgbe_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 2856486..813c5bc 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work) } hw->mac.ops.setup_sfp(hw); - if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK) + if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)) /* This will also work for DA Twinax connections */ schedule_work(&adapter->multispeed_fiber_task); adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;