| Message ID | 1239093575-12147-1-git-send-email-sr@denx.de (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
Stefan Roese wrote: > This property is unused. It's not handled as all by the physmap_of > driver. So let's remove it from the documentation. > > Signed-off-by: Stefan Roese <sr@denx.de> > CC: Grant Likely <grant.likely@secretlab.ca> The device tree describes the hardware, not what Linux happens to do with it at the moment. I'd rather keep it. -Scott
On Tuesday 07 April 2009, Scott Wood wrote: > Stefan Roese wrote: > > This property is unused. It's not handled as all by the physmap_of > > driver. So let's remove it from the documentation. > > > > Signed-off-by: Stefan Roese <sr@denx.de> > > CC: Grant Likely <grant.likely@secretlab.ca> > > The device tree describes the hardware, not what Linux happens to do > with it at the moment. > > I'd rather keep it. I find it rather confusing to "see" such bindings that are not supported. One could expect something to happen/change after defining this property. So in general I think adding unsupported properties to the Documentation is a bad idea. But that's just my 2 cents. If the general opinion is to keep this property, I'll keep it in of course. Best regards, Stefan
On Tue, Apr 7, 2009 at 10:54 AM, Stefan Roese <sr@denx.de> wrote: > On Tuesday 07 April 2009, Scott Wood wrote: >> Stefan Roese wrote: >> > This property is unused. It's not handled as all by the physmap_of >> > driver. So let's remove it from the documentation. >> > >> > Signed-off-by: Stefan Roese <sr@denx.de> >> > CC: Grant Likely <grant.likely@secretlab.ca> >> >> The device tree describes the hardware, not what Linux happens to do >> with it at the moment. >> >> I'd rather keep it. > > I find it rather confusing to "see" such bindings that are not supported. One > could expect something to happen/change after defining this property. So in > general I think adding unsupported properties to the Documentation is a bad > idea. But that's just my 2 cents. If the general opinion is to keep this > property, I'll keep it in of course. I say keep it. It is a valid way to describe the hardware regardless of whether or not the driver supports it yet. g.
diff --git a/Documentation/powerpc/dts-bindings/mtd-physmap.txt b/Documentation/powerpc/dts-bindings/mtd-physmap.txt index cd474f9..ab1115e 100644 --- a/Documentation/powerpc/dts-bindings/mtd-physmap.txt +++ b/Documentation/powerpc/dts-bindings/mtd-physmap.txt @@ -8,8 +8,6 @@ file systems on embedded devices. - reg : Address range of the flash chip - bank-width : Width (in bytes) of the flash bank. Equal to the device width times the number of interleaved chips. - - device-width : (optional) Width of a single flash chip. If - omitted, assumed to be equal to 'bank-width'. - #address-cells, #size-cells : Must be present if the flash has sub-nodes representing partitions (see below). In this case both #address-cells and #size-cells must be equal to 1. @@ -48,7 +46,6 @@ Example: compatible = "amd,am29lv128ml", "cfi-flash"; reg = <ff000000 01000000>; bank-width = <4>; - device-width = <1>; #address-cells = <1>; #size-cells = <1>; fs@0 {
This property is unused. It's not handled as all by the physmap_of driver. So let's remove it from the documentation. Signed-off-by: Stefan Roese <sr@denx.de> CC: Grant Likely <grant.likely@secretlab.ca> --- Documentation/powerpc/dts-bindings/mtd-physmap.txt | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)