Patchwork [U-Boot,v5,06/14] cfi_flash: use buffer length in unmap_physmem()

login
register
mail settings
Submitter Kuo-Jung Su
Date June 17, 2013, 12:06 p.m.
Message ID <1371470824-3228-7-git-send-email-dantesu@gmail.com>
Download mbox | patch
Permalink /patch/251828/
State Superseded
Delegated to: Stefan Roese
Headers show

Comments

Kuo-Jung Su - June 17, 2013, 12:06 p.m.
From: Kuo-Jung Su <dantesu@faraday-tech.com>

While the flash_detect_legacy() of drivers/mtd/cfi_flash.c
feed unmap_physmem() with MAP_NOCACHE as 2nd parameter,
the do_spi_flash_read_write() of common/cmd_sf.c
feed unmap_physmem() with the length of the mapped buffer
as 2nd parameter.

It's apparently a bug, and I personally think the 2nd parameter
should be the length of the mapped buffer.

Signed-off-by: Kuo-Jung Su <dantesu@faraday-tech.com>
CC: Albert Aribaud <albert.u.boot@aribaud.net>
CC: Stefan Roese <sr@denx.de>
---
Changes for v5:
   - Initial commit, which is separated from
     "arm: add MMU/D-Cache support for Faraday cores"

 drivers/mtd/cfi_flash.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.7.9.5

Patch

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 25f8752..0d7a5ac 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -1820,7 +1820,7 @@  static int flash_detect_legacy(phys_addr_t base, int banknum)
 					break;
 				else
 					unmap_physmem((void *)info->start[0],
-						      MAP_NOCACHE);
+						      info->portwidth);
 			}
 		}