| Message ID | 1371111467.24768.3.camel@phoenix |
|---|---|
| State | Accepted |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
Dear Axel Lin, > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > Forgot to CC mailing list, so here is a resend. > drivers/spi/tegra114_spi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/spi/tegra114_spi.c b/drivers/spi/tegra114_spi.c > index b11a0a1..4d2af48 100644 > --- a/drivers/spi/tegra114_spi.c > +++ b/drivers/spi/tegra114_spi.c > @@ -152,13 +152,11 @@ struct spi_slave *tegra114_spi_setup_slave(unsigned > int bus, unsigned int cs, return NULL; > } > > - spi = malloc(sizeof(struct tegra_spi_slave)); > + spi = spi_alloc_slave(struct tegra_spi_slave, bus, cs); > if (!spi) { > printf("SPI error: malloc of SPI structure failed\n"); > return NULL; > } > - spi->slave.bus = bus; > - spi->slave.cs = cs; > spi->ctrl = &spi_ctrls[bus]; > if (!spi->ctrl) { > printf("SPI error: could not find controller for bus %d\n", Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut
On 13-06-2013 16:18, Marek Vasut wrote: > Dear Axel Lin, > >> Signed-off-by: Axel Lin <axel.lin@ingics.com> >> --- >> Forgot to CC mailing list, so here is a resend. >> drivers/spi/tegra114_spi.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/spi/tegra114_spi.c b/drivers/spi/tegra114_spi.c >> index b11a0a1..4d2af48 100644 >> --- a/drivers/spi/tegra114_spi.c >> +++ b/drivers/spi/tegra114_spi.c >> @@ -152,13 +152,11 @@ struct spi_slave *tegra114_spi_setup_slave(unsigned >> int bus, unsigned int cs, return NULL; >> } >> >> - spi = malloc(sizeof(struct tegra_spi_slave)); >> + spi = spi_alloc_slave(struct tegra_spi_slave, bus, cs); >> if (!spi) { >> printf("SPI error: malloc of SPI structure failed\n"); >> return NULL; >> } >> - spi->slave.bus = bus; >> - spi->slave.cs = cs; >> spi->ctrl = &spi_ctrls[bus]; >> if (!spi->ctrl) { >> printf("SPI error: could not find controller for bus %d\n", > > Acked-by: Marek Vasut <marex@denx.de> > > Best regards, > Marek Vasut > Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com> -- Thanks, Jagan.
On 13-06-2013 13:47, Axel Lin wrote: > Signed-off-by: Axel Lin <axel.lin@ingics.com> > Acked-by: Marek Vasut <marex@denx.de> > Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com> > > --- > Forgot to CC mailing list, so here is a resend. > drivers/spi/tegra114_spi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/spi/tegra114_spi.c b/drivers/spi/tegra114_spi.c > index b11a0a1..4d2af48 100644 > --- a/drivers/spi/tegra114_spi.c > +++ b/drivers/spi/tegra114_spi.c > @@ -152,13 +152,11 @@ struct spi_slave *tegra114_spi_setup_slave(unsigned int bus, unsigned int cs, > return NULL; > } > > - spi = malloc(sizeof(struct tegra_spi_slave)); > + spi = spi_alloc_slave(struct tegra_spi_slave, bus, cs); > if (!spi) { > printf("SPI error: malloc of SPI structure failed\n"); > return NULL; > } > - spi->slave.bus = bus; > - spi->slave.cs = cs; > spi->ctrl = &spi_ctrls[bus]; > if (!spi->ctrl) { > printf("SPI error: could not find controller for bus %d\n", > Applied to u-boot-spi/master -- Thanks, Jagan.
diff --git a/drivers/spi/tegra114_spi.c b/drivers/spi/tegra114_spi.c index b11a0a1..4d2af48 100644 --- a/drivers/spi/tegra114_spi.c +++ b/drivers/spi/tegra114_spi.c @@ -152,13 +152,11 @@ struct spi_slave *tegra114_spi_setup_slave(unsigned int bus, unsigned int cs, return NULL; } - spi = malloc(sizeof(struct tegra_spi_slave)); + spi = spi_alloc_slave(struct tegra_spi_slave, bus, cs); if (!spi) { printf("SPI error: malloc of SPI structure failed\n"); return NULL; } - spi->slave.bus = bus; - spi->slave.cs = cs; spi->ctrl = &spi_ctrls[bus]; if (!spi->ctrl) { printf("SPI error: could not find controller for bus %d\n",
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- Forgot to CC mailing list, so here is a resend. drivers/spi/tegra114_spi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)