| Message ID | 1369822195-5277-3-git-send-email-lokeshvutla@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, May 29, 2013 at 03:39:54PM +0530, Lokesh Vutla wrote: > From: Sricharan R <r.sricharan@ti.com> > > SGX clocks should be enabled only for OMAP5 ES1.0. > So this can be removed. > > Signed-off-by: Sricharan R <r.sricharan@ti.com> > --- > arch/arm/cpu/armv7/omap5/hw_data.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c > index 604fa42..842cf27 100644 > --- a/arch/arm/cpu/armv7/omap5/hw_data.c > +++ b/arch/arm/cpu/armv7/omap5/hw_data.c > @@ -383,12 +383,6 @@ void enable_basic_clocks(void) > clk_modules_explicit_en_essential, > 1); > > - /* Select 384Mhz for GPU as its the POR for ES1.0 */ > - setbits_le32((*prcm)->cm_sgx_sgx_clkctrl, > - CLKSEL_GPU_HYD_GCLK_MASK); > - setbits_le32((*prcm)->cm_sgx_sgx_clkctrl, > - CLKSEL_GPU_CORE_GCLK_MASK); > - > /* Enable SCRM OPT clocks for PER and CORE dpll */ > setbits_le32((*prcm)->cm_wkupaon_scrm_clkctrl, > OPTFCLKEN_SCRM_PER_MASK); Wait, will everyone with ES1.0 be updating to ES2.0 and be OK with this? Lubomir's board is ES1.0, currently. Thanks!
On Wednesday 29 May 2013 06:10 PM, Tom Rini wrote: > On Wed, May 29, 2013 at 03:39:54PM +0530, Lokesh Vutla wrote: > >> From: Sricharan R <r.sricharan@ti.com> >> >> SGX clocks should be enabled only for OMAP5 ES1.0. >> So this can be removed. >> >> Signed-off-by: Sricharan R <r.sricharan@ti.com> >> --- >> arch/arm/cpu/armv7/omap5/hw_data.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c >> index 604fa42..842cf27 100644 >> --- a/arch/arm/cpu/armv7/omap5/hw_data.c >> +++ b/arch/arm/cpu/armv7/omap5/hw_data.c >> @@ -383,12 +383,6 @@ void enable_basic_clocks(void) >> clk_modules_explicit_en_essential, >> 1); >> >> - /* Select 384Mhz for GPU as its the POR for ES1.0 */ >> - setbits_le32((*prcm)->cm_sgx_sgx_clkctrl, >> - CLKSEL_GPU_HYD_GCLK_MASK); >> - setbits_le32((*prcm)->cm_sgx_sgx_clkctrl, >> - CLKSEL_GPU_CORE_GCLK_MASK); >> - >> /* Enable SCRM OPT clocks for PER and CORE dpll */ >> setbits_le32((*prcm)->cm_wkupaon_scrm_clkctrl, >> OPTFCLKEN_SCRM_PER_MASK); > Wait, will everyone with ES1.0 be updating to ES2.0 and be OK with this? > Lubomir's board is ES1.0, currently. Thanks! Even if so, these clocks should/need not be enabled in boot loader. It should not have been enabled in, but earlier we had the habit enabling unnessecary things.. Regards, Sricharan
diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c index 604fa42..842cf27 100644 --- a/arch/arm/cpu/armv7/omap5/hw_data.c +++ b/arch/arm/cpu/armv7/omap5/hw_data.c @@ -383,12 +383,6 @@ void enable_basic_clocks(void) clk_modules_explicit_en_essential, 1); - /* Select 384Mhz for GPU as its the POR for ES1.0 */ - setbits_le32((*prcm)->cm_sgx_sgx_clkctrl, - CLKSEL_GPU_HYD_GCLK_MASK); - setbits_le32((*prcm)->cm_sgx_sgx_clkctrl, - CLKSEL_GPU_CORE_GCLK_MASK); - /* Enable SCRM OPT clocks for PER and CORE dpll */ setbits_le32((*prcm)->cm_wkupaon_scrm_clkctrl, OPTFCLKEN_SCRM_PER_MASK);