Message ID | 1369331424-25835-2-git-send-email-fabio.estevam@freescale.com |
---|---|
State | Rejected |
Delegated to: | Stefano Babic |
Headers | show |
Hi Fabio, On Thu, 23 May 2013 14:50:24 -0300 Fabio Estevam <fabio.estevam@freescale.com> wrote: > Currently HDMI framebuffer only works if we disable data cache. > > Disable data cache until the proper fix is found. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Hi, > > If someone has any suggestion for a proper fix, please let me know. There is a patch for a proper fix, queued in my video repo: http://git.denx.de/?p=u-boot/u-boot-video.git;a=commit;h=db0d47dd433bc7ba60b927fb0ff6835758a8893d Thanks, Anatolij
Hi Anatolij, On Thu, May 23, 2013 at 4:31 PM, Anatolij Gustschin <agust@denx.de> wrote: > > There is a patch for a proper fix, queued in my video repo: > > http://git.denx.de/?p=u-boot/u-boot-video.git;a=commit;h=db0d47dd433bc7ba60b927fb0ff6835758a8893d Excellent, just applied this patch, kept dcache on and the splash can be seen withour distortion. Thanks, Fabio Estevam
Dear Fabio Estevam, In message <1369331424-25835-2-git-send-email-fabio.estevam@freescale.com> you wrote: > Currently HDMI framebuffer only works if we disable data cache. > > Disable data cache until the proper fix is found. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Hi, > > If someone has any suggestion for a proper fix, please let me know. Even without a proper fix this should not be done unconditionally. Please do this only when you actually have to, i. e. when really using the HDMI framebuffer in a system. It's not a good idea to let all others suffer from that. Also, I wonder if we should issue a warning then (at build time). Best regards, Wolfgang Denk
Hi Wolfgang, On Thu, May 23, 2013 at 6:12 PM, Wolfgang Denk <wd@denx.de> wrote: > Even without a proper fix this should not be done unconditionally. > Please do this only when you actually have to, i. e. when really using > the HDMI framebuffer in a system. It's not a good idea to let all > others suffer from that. Right, I should have marked this patch as RFC. Anatolij kindly pointed me to a patch that solves the problem, so this one can be discarded. Regards, Fabio Estevam
diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h index d4ac086..5a3f0fc 100644 --- a/include/configs/wandboard.h +++ b/include/configs/wandboard.h @@ -98,6 +98,7 @@ #define CONFIG_BMP_16BPP #define CONFIG_VIDEO_LOGO #define CONFIG_IPUV3_CLK 260000000 +#define CONFIG_SYS_DCACHE_OFF #if defined(CONFIG_MX6DL) #define CONFIG_DEFAULT_FDT_FILE "imx6dl-wandboard.dtb"
Currently HDMI framebuffer only works if we disable data cache. Disable data cache until the proper fix is found. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- Hi, If someone has any suggestion for a proper fix, please let me know. Thanks include/configs/wandboard.h | 1 + 1 file changed, 1 insertion(+)