Patchwork [3.8.y.z,extended,stable] Patch "dm snapshot: fix error return code in snapshot_ctr" has been added to staging queue

mail settings
Submitter Kamal Mostafa
Date May 22, 2013, 9:55 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/245759/
State New
Headers show


Kamal Mostafa - May 22, 2013, 9:55 p.m.
This is a note to let you know that I have just added a patch titled

    dm snapshot: fix error return code in snapshot_ctr

to the linux-3.8.y-queue branch of the 3.8.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.8.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.8.y.z tree, see



From f56e54330556eb63399eb84dc87e14fe61e8ba6d Mon Sep 17 00:00:00 2001
From: Wei Yongjun <>
Date: Fri, 10 May 2013 14:37:15 +0100
Subject: dm snapshot: fix error return code in snapshot_ctr

commit 09e8b813897a0f85bb401435d009228644c81214 upstream.

Return -ENOMEM instead of success if unable to allocate pending
exception mempool in snapshot_ctr.

Signed-off-by: Wei Yongjun <>
Signed-off-by: Alasdair G Kergon <>
Signed-off-by: Kamal Mostafa <>
 drivers/md/dm-snap.c | 1 +
 1 file changed, 1 insertion(+)



diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c
index df74f9f..900eb23 100644
--- a/drivers/md/dm-snap.c
+++ b/drivers/md/dm-snap.c
@@ -1119,6 +1119,7 @@  static int snapshot_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 	s->pending_pool = mempool_create_slab_pool(MIN_IOS, pending_cache);
 	if (!s->pending_pool) {
 		ti->error = "Could not allocate mempool for pending exceptions";
+		r = -ENOMEM;
 		goto bad_pending_pool;