Message ID | 1367178711-8232-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
On Mon, Apr 29, 2013 at 01:21:45AM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> What's the difference in meaning between pmd_huge() and pmd_large()? > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > --- > arch/powerpc/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c > index 8601f2d..081c001 100644 > --- a/arch/powerpc/mm/hugetlbpage.c > +++ b/arch/powerpc/mm/hugetlbpage.c > @@ -954,7 +954,7 @@ pte_t *find_linux_pte_or_hugepte(pgd_t *pgdir, unsigned long ea, unsigned *shift > pdshift = PMD_SHIFT; > pm = pmd_offset(pu, ea); > > - if (pmd_huge(*pm)) { > + if (pmd_huge(*pm) || pmd_large(*pm)) { > ret_pte = (pte_t *) pm; > goto out; > } else if (is_hugepd(pm))
David Gibson <dwg@au1.ibm.com> writes: > On Mon, Apr 29, 2013 at 01:21:45AM +0530, Aneesh Kumar K.V wrote: >> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > > What's the difference in meaning between pmd_huge() and pmd_large()? > #ifndef CONFIG_HUGETLB_PAGE #define pmd_huge(x) 0 #endif Also pmd_large do check for THP PTE flag, and _PAGE_PRESENT. -aneesh
On Sat, May 04, 2013 at 12:28:20AM +0530, Aneesh Kumar K.V wrote: > David Gibson <dwg@au1.ibm.com> writes: > > > On Mon, Apr 29, 2013 at 01:21:45AM +0530, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > > > > What's the difference in meaning between pmd_huge() and pmd_large()? > > > > #ifndef CONFIG_HUGETLB_PAGE > #define pmd_huge(x) 0 > #endif > > Also pmd_large do check for THP PTE flag, and _PAGE_PRESENT. I don't mean what's the code difference. I mean what is the semantic difference between pmd_huge() and pmd_large() supposed to be - in words.
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c index 8601f2d..081c001 100644 --- a/arch/powerpc/mm/hugetlbpage.c +++ b/arch/powerpc/mm/hugetlbpage.c @@ -954,7 +954,7 @@ pte_t *find_linux_pte_or_hugepte(pgd_t *pgdir, unsigned long ea, unsigned *shift pdshift = PMD_SHIFT; pm = pmd_offset(pu, ea); - if (pmd_huge(*pm)) { + if (pmd_huge(*pm) || pmd_large(*pm)) { ret_pte = (pte_t *) pm; goto out; } else if (is_hugepd(pm))