Patchwork [U-Boot] powerpc: Use lower case for the core names

login
register
mail settings
Submitter Fabio Estevam
Date April 21, 2013, 4:11 p.m.
Message ID <1366560666-23691-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/238226/
State Accepted
Delegated to: Andy Fleming
Headers show

Comments

Fabio Estevam - April 21, 2013, 4:11 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Freescale documentation presents the PowerPC core names in lower case, such as
"e300", "e500", "e600", etc.

Change the upper case occurrences into lower case so that the core names 
reported in U-boot can match the ones from the documentation.

While at it also fix a checkpatch error:

ERROR: space prohibited before that close parenthesis ')'
#53: FILE: arch/powerpc/cpu/mpc86xx/cpu.c:81:
+	printf("e600 Core %d", (msscr0 & 0x20) ? 1 : 0 );

Reported-by: Heinz Wrobel <heinz.wrobel@freescale.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/powerpc/cpu/mpc85xx/cpu.c |    8 ++++----
 arch/powerpc/cpu/mpc86xx/cpu.c |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
Andy Fleming - June 21, 2013, 8:43 p.m.
On Sun, Apr 21, 2013 at 01:11:02PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Freescale documentation presents the PowerPC core names in lower case, such as
> "e300", "e500", "e600", etc.
> 
> Change the upper case occurrences into lower case so that the core names 
> reported in U-boot can match the ones from the documentation.
> 
> While at it also fix a checkpatch error:
> 
> ERROR: space prohibited before that close parenthesis ')'
> #53: FILE: arch/powerpc/cpu/mpc86xx/cpu.c:81:
> +	printf("e600 Core %d", (msscr0 & 0x20) ? 1 : 0 );
> 
> Reported-by: Heinz Wrobel <heinz.wrobel@freescale.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied, thanks!

Andy

Patch

diff --git a/arch/powerpc/cpu/mpc85xx/cpu.c b/arch/powerpc/cpu/mpc85xx/cpu.c
index df2ab6d..e88ee26 100644
--- a/arch/powerpc/cpu/mpc85xx/cpu.c
+++ b/arch/powerpc/cpu/mpc85xx/cpu.c
@@ -121,16 +121,16 @@  int checkcpu (void)
 	switch(ver) {
 	case PVR_VER_E500_V1:
 	case PVR_VER_E500_V2:
-		puts("E500");
+		puts("e500");
 		break;
 	case PVR_VER_E500MC:
-		puts("E500MC");
+		puts("e500mc");
 		break;
 	case PVR_VER_E5500:
-		puts("E5500");
+		puts("e5500");
 		break;
 	case PVR_VER_E6500:
-		puts("E6500");
+		puts("e6500");
 		break;
 	default:
 		puts("Unknown");
diff --git a/arch/powerpc/cpu/mpc86xx/cpu.c b/arch/powerpc/cpu/mpc86xx/cpu.c
index c553415..b8b1d8f 100644
--- a/arch/powerpc/cpu/mpc86xx/cpu.c
+++ b/arch/powerpc/cpu/mpc86xx/cpu.c
@@ -78,7 +78,7 @@  checkcpu(void)
 	major = PVR_E600_MAJ(pvr);
 	minor = PVR_E600_MIN(pvr);
 
-	printf("E600 Core %d", (msscr0 & 0x20) ? 1 : 0 );
+	printf("e600 Core %d", (msscr0 & 0x20) ? 1 : 0);
 	if (gur->pordevsr & MPC86xx_PORDEVSR_CORE1TE)
 		puts("\n    Core1Translation Enabled");
 	debug(" (MSSCR0=%x, PORDEVSR=%x)", msscr0, gur->pordevsr);