Patchwork [07/22] linux-user: Use absolute include path

login
register
mail settings
Submitter Lluís Vilanova
Date March 26, 2013, 2:01 p.m.
Message ID <20130326140100.4471.33758.stgit@fimbulvetr.bsc.es>
Download mbox | patch
Permalink /patch/231207/
State New
Headers show

Comments

Lluís Vilanova - March 26, 2013, 2:01 p.m.
Lets the include directive work regardless of the current directory.

This is needed for code compiled in directories deeper than one level from the
build root.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 Makefile.target |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Peter Maydell - March 26, 2013, 2:06 p.m.
On 26 March 2013 14:01, Lluís Vilanova <vilanova@ac.upc.edu> wrote:
> Lets the include directive work regardless of the current directory.
>
> This is needed for code compiled in directories deeper than one level from the
> build root.

Something odd here -- linux-headers/ is not for
linux-user mode, it's only needed for system mode (and
specifically for KVM support). Possibly just an error
in the commit message? I think the code change looks OK.

-- PMM
Lluís Vilanova - March 26, 2013, 3:15 p.m.
Peter Maydell writes:

> On 26 March 2013 14:01, Lluís Vilanova <vilanova@ac.upc.edu> wrote:
>> Lets the include directive work regardless of the current directory.
>> 
>> This is needed for code compiled in directories deeper than one level from the
>> build root.

> Something odd here -- linux-headers/ is not for
> linux-user mode, it's only needed for system mode (and
> specifically for KVM support). Possibly just an error
> in the commit message? I think the code change looks OK.

That's right, fixed.


Thanks,
  Lluis

Patch

diff --git a/Makefile.target b/Makefile.target
index 310471b..af299a0 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -7,7 +7,7 @@  include $(SRC_PATH)/rules.mak
 
 $(call set-vpath, $(SRC_PATH))
 ifdef CONFIG_LINUX
-QEMU_CFLAGS += -I../linux-headers
+QEMU_CFLAGS += -I$(BUILD_DIR)/linux-headers
 endif
 QEMU_CFLAGS += -I.. -I$(SRC_PATH)/target-$(TARGET_BASE_ARCH) -DNEED_CPU_H